Repository navigation
Implement ClassFox 2.1 domestic and offline downloads - #15
Merged
Merged
Conversation
Root cause: Downloads depended on overseas endpoints without automatic recovery or an offline installation path. Solution: Prefer a pinned identical ModelScope Qwen asset, retry and resume downloads, and validate native-selected offline ZIP packages. Bundle hash-checked VAD and platform runtimes in 2.1.0 installers. Risks: Domestic availability varies by network; verify native packages on all supported platforms and preserve upstream model notices. Dependency: ModelScope pinned Qwen asset and llama.cpp b10964 assets Links: plan/02-v1-domestic-downloads.md
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c2918ccdb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Root cause: Offline imports copied entire weights without publishing byte progress, and documentation advertised an unverified share. Solution: Report copy progress on the event loop and describe the Baidu download entry as pending until upload and sharing are verified. Risks: Thread-originated progress must remain on the event loop. Dependency: 2c2918c Links: #15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users on domestic networks can fail to download models from Hugging Face and GitHub. ClassFox 2.1 adds a pinned, identical ModelScope Qwen source with fallback and automatic retry/resume, plus a native ZIP picker and authenticated offline import that checks known file sizes, SHA-256 and actual model loading before activation. Existing installed fingerprints stay compatible.
Installers now contain hash-verified Silero VAD and the platform llama.cpp archive. A reproducible script prepares attributed, portable model ZIPs and checksums. Baidu Netdisk links will be added after the verified release artifacts have been uploaded, as requested.
Validation: the final full backend suite passed all 199 tests after both review fixes (corrupt-prefix download recovery and incremental offline import progress). Three script tests, 22 frontend tests, type checks, lint/format, strict docs build and 10 real Edge browser scenarios passed. Both actual offline model ZIPs reached ready through real ASR/LLM probes with all external HTTP calls denied. One fresh whole-change review found the recovery regression; its new test failed before the fix and passed after.
Final CI run 38790182529 passed on Windows x64, macOS Intel and Apple Silicon, including native builds and frozen-backend verification. Documentation CI also passed. The final Apple Silicon DMG was additionally verified locally: DMG checksums, architecture, version, ad-hoc signature, packaged VAD/runtime hashes and bundled backend self-check all passed. No paid infrastructure or credentials are introduced. Model redistribution keeps full license and attribution notices; upstream SenseVoice commercial-license clarification remains open. Merge using Rebase and merge.
Plan: plan/02-v1-domestic-downloads.md