Document presigned PUT upload response on /attachments.create#31
Merged
Conversation
Reflects the new `mode` field and the alternate `url` / `headers` response shape returned when AWS_S3_UPLOAD_METHOD is set to "put" (outline/outline#12748).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
/attachments.createto reflect the new response shape introduced in outline/outline#12748, which adds support for presigned PUT uploads to S3-compatible providers (e.g. Cloudflare R2) that don't implement presigned POST.The response now includes a
modefield that switches the rest of the payload:mode: "post"(default) — existinguploadUrlandformfields are returned.mode: "put"— newurlandheadersfields are returned instead; the client performs a single PUT with those headers.Only
spec3.ymlis updated;spec3.jsonis regenerated by the pre-commit hook on merge.Test plan
python3 -c "import yaml; yaml.safe_load(open('spec3.yml'))")Generated by Claude Code