Changes to add wheels for 3.13t/3.14t#208
Merged
Merged
Conversation
|
I wouldn't worry about 3.13t. It was experimental and is being removed from cibuildwheel, pybind11, etc. Just focus on 3.14t+. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both these commits are thanks to Claude Code! The first one was just poor C on my part, which was always technically a bug but only showed up as a segfault in
python 3.13twhich has aggressive memory management. Here is the summary from claude:The second commit is related to
cmakebeing able to find the correct python interpreter (and avoid the situation where it finds a3.13where it should be finding a3.13t. Again, here is the summary from claude:Note that we're still not saying that we'll work correctly without the GIL and we're asking it to be enabled (by not saying
py::mod_gil_not_used()in our bindings - that's a separate issue.I've gone through all changes carefully and they make sense, though I'll also run the second commit by @henryiii just to get his thoughts on this.