fix(mas): build-mas.sh survives no-Frameworks bundle; add App Store entitlements#186
Open
oratis wants to merge 1 commit into
Open
fix(mas): build-mas.sh survives no-Frameworks bundle; add App Store entitlements#186oratis wants to merge 1 commit into
oratis wants to merge 1 commit into
Conversation
…ntitlements Two bugs surfaced on the first real Mac App Store build of Markup: 1. build-mas.sh step 3 ran `find "$APP/Contents/Frameworks"` unconditionally. tauri.conf.json sets "frameworks": [], so Markup.app has no Contents/Frameworks dir; find exits non-zero and `set -o pipefail` killed the script before any codesign ran. Guard the find with a directory check. 2. Entitlements.mas.plist lacked com.apple.application-identifier and com.apple.developer.team-identifier, which App Store signing requires (the .pkg upload is rejected without them). Add both (9LH9NBX7P4.com.appkon.markup / 9LH9NBX7P4). Verified by building a signed, sandboxed Markup.pkg (v1.0.1) locally: pkgutil chain = "3rd Party Mac Developer Installer: Bihao Wang"; embedded app signed by "Apple Distribution: Bihao Wang" with app-sandbox + application-identifier + the embedded provisioning profile; codesign --verify --deep --strict passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First real Mac App Store build of Markup hit two bugs in the MAS pipeline. Both fixed and verified by producing a valid signed
Markup.pkg(v1.0.1) locally.Bugs
build-mas.shdied before signing. Step 3 ranfind "$APP/Contents/Frameworks"unconditionally, buttauri.conf.jsonsets"frameworks": []→Markup.apphas noContents/Frameworksdir →findexits non-zero →set -o pipefailkilled the script. The log jumped straight from==> 3/5 Signing…toexit code 1with no codesign output. Fix: guard thefindwith[ -d … ].Missing App Store entitlements.
Entitlements.mas.plisthad only the sandbox keys; App Store signing also requirescom.apple.application-identifierandcom.apple.developer.team-identifier(the.pkgupload is rejected without them). Fix: add both (9LH9NBX7P4.com.appkon.markup/9LH9NBX7P4).Verification (local signed build)
pkgutil --check-signature→3rd Party Mac Developer Installer: Bihao Wang (9LH9NBX7P4)→ Apple WWDRApple Distribution: Bihao Wang→ WWDR → Apple Root CA;com.appkon.markupv1.0.1app-sandbox,application-identifier,team-identifier,files.user-selected.read-write,files.bookmarks.app-scope,network.clientembedded.provisionprofilepresent;codesign --verify --deep --strictpassesUnblocks the dormant CI
masjob for future releases. No effect on the direct-DMG build (separateEntitlements.plist+sign-and-notarize.sh).🤖 Generated with Claude Code