Skip to content

fix: standardize charset encoding in test fixtures #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chilingling merged 1 commit into from
May 29, 2026
Merged

fix: standardize charset encoding in test fixtures #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions base/src/test/java/com/tinyengine/it/common/utils/UtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ void testCleanUp_DeleteTempDirFails() throws IOException {

@Test
void testReadAllBytes_Normal() throws IOException {
byte[] expected = "Hello, World!".getBytes();
byte[] expected = "Hello, World!".getBytes(StandardCharsets.UTF_8);
try (InputStream is = new ByteArrayInputStream(expected)) {
byte[] result = Utils.readAllBytes(is);
assertThat(result).isEqualTo(expected);
Expand Down Expand Up @@ -908,7 +908,7 @@ void testReadAllBytes() throws Exception {
}
@Test
public void test_readAllBytes_Normal() throws IOException {
byte[] expectedBytes = "test data".getBytes();
byte[] expectedBytes = "test data".getBytes(StandardCharsets.UTF_8);
try (InputStream inputStream = new ByteArrayInputStream(expectedBytes)) {
byte[] result = Utils.readAllBytes(inputStream);
assertArrayEquals(expectedBytes, result);
Expand Down Expand Up @@ -1013,7 +1013,7 @@ void testCreateTempDirectory_Success() throws IOException {
@Test
void testConvertMultipartFileToFile_Success() throws IOException {
// 准备 MultipartFile（使用 Spring MockMultipartFile）
byte[] content = "Hello, World!".getBytes();
byte[] content = "Hello, World!".getBytes(StandardCharsets.UTF_8);
MultipartFile multipartFile = new MockMultipartFile(
"file", "test.txt", "text/plain", content);
List<File> createdFiles = new ArrayList<>();
Expand Down Expand Up @@ -1249,7 +1249,7 @@ void testUnzip_ZipWithOnlyDirectories() throws IOException {
@Test
void testUnzip_InvalidZipFile() throws IOException {
// 非法的 ZIP 数据（随机字节）
byte[] invalidZip = "this is not a zip file".getBytes();
byte[] invalidZip = "this is not a zip file".getBytes(StandardCharsets.UTF_8);
MultipartFile multipartFile = new MockMultipartFile("file", "bad.zip", "application/zip", invalidZip);

// 实际行为可能是抛出 IOException，也可能返回空列表（如果方法内部处理了异常）
Expand Down
Loading