Add rosa-sts-e2e Prow e2e tests for osd-metrics-exporter by redhat-chai-bot · Pull Request #85427 · openshift/release

redhat-chai-bot · 2026-09-17T20:06:12Z

Adds ci-operator configuration for osd-metrics-exporter (OME) with Prow e2e tests using the rosa-cluster-lease-e2e-workflow, following the pattern established by route-monitor-operator.

Changes

base_images: ocm-cli and rosa-aws-cli
images: operator (build/Dockerfile), operator-pko (from deploy_pko/), operator-e2e (compiled e2e test binary with osde2e build tag)
releases: OCP 4.21 candidate/ci stream
rosa-sts-e2e: presubmit test
rosa-sts-e2e-promotion-int: periodic (gangway-triggered via cron: 0 0 31 2 *, LEASE_ENV=integration)
rosa-sts-e2e-promotion-stage: periodic (gangway-triggered via cron: 0 0 31 2 *, LEASE_ENV=staging)

Generated prowjob definitions via make ci-operator-config && make jobs.

Part of the Prow e2e onboarding for OME (ROSAENG-61844).

AI-generated. Review for accuracy.

@dustman9000 requested via Chai Bot

Summary by CodeRabbit

Adds CI configuration for openshift/osd-metrics-exporter.
Defines ocm-cli and rosa-aws-cli base images.
Adds operator, PKO, and end-to-end test images.
Configures OCP 4.21 candidate and CI release streams.
Adds ROSA STS end-to-end presubmit and scheduled integration/staging promotion tests using rosa-cluster-lease-e2e-workflow.
Adds generated ProwJob definitions for OME onboarding.

coderabbitai · 2026-09-17T20:06:47Z

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: c21e02fb-4cb0-47e0-99f0-4b6e5bc35e36

📥 Commits

Reviewing files that changed from the base of the PR and between c3655d0 and f1c5c45.

⛔ Files ignored due to path filters (3)

ci-operator/jobs/openshift/osd-metrics-exporter/openshift-osd-metrics-exporter-main-periodics.yaml is excluded by !ci-operator/jobs/**
ci-operator/jobs/openshift/osd-metrics-exporter/openshift-osd-metrics-exporter-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
ci-operator/jobs/openshift/osd-metrics-exporter/openshift-osd-metrics-exporter-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

ci-operator/config/openshift/osd-metrics-exporter/openshift-osd-metrics-exporter-main.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

Walkthrough

The CI configuration adds exporter build inputs and image targets, declares an OCP 4.21 release candidate, and adds ROSA STS end-to-end and promotion jobs.

Changes

OSD Metrics Exporter CI

Layer / File(s)	Summary
Build artifacts and release stream `ci-operator/config/openshift/osd-metrics-exporter/openshift-osd-metrics-exporter-main.yaml`	The configuration adds `ocm-cli` and `rosa-aws-cli` base images, defines `operator-pko` and `operator-e2e` build items, renames the exporter image target, and declares an OCP 4.21 `latest` release candidate.
ROSA end-to-end workflows `ci-operator/config/openshift/osd-metrics-exporter/openshift-osd-metrics-exporter-main.yaml`	The configuration adds one ROSA STS end-to-end job and scheduled integration and staging promotion jobs with workflow dependencies, environment variables, lease environments, and reporter settings.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Suggested reviewers: psalajova

Merge Risk: ⚪ Minimal · up to f1c5c

This change adds standard ci-operator configuration for ROSA STS end-to-end and promotion testing of osd-metrics-exporter, following an established pattern from other operators. The one flagged concern about a potential staging/integration environment mismatch was investigated and found not to be an actual issue, since the underlying workflow resolves the login environment from the claimed cluster lease rather than a static default. No blocking issues remain.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Ipv6 And Disconnected Network Test Compatibility	⚠️ Warning	The PR adds three ROSA Ginkgo e2e jobs through `rosa-cluster-lease-e2e-workflow`. That workflow runs `rosa-operator-e2e`; its command logs into the external OCM service with `ocm login --url "${OCM_LO…	IPv6 and disconnected network compatibility notice: This test may contain IPv4 assumptions or external connectivity requirements that will fail in IPv6-only disconnected environments. Please verify your test works on IPv6 by running an …

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding ROSA STS Prow end-to-end tests for osd-metrics-exporter.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only ci-operator configuration and generated Prow job YAML. The authoritative diff adds no Ginkgo title declarations such as It(), Describe(), Context(), or When(). The new GINKGO_FOCUS…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only four YAML files under ci-operator configuration and generated ProwJob definitions. It adds an e2e test image build and workflow declarations, but it does not add or…
Microshift Test Compatibility	✅ Passed	The pull request changes only CI configuration and generated ProwJob definitions. The authoritative diff contains no Go test files, Ginkgo declarations, or e2e test source changes. Therefore, this Mic…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only CI configuration and generated Prow job YAML. The authoritative diff contains no Go or other test-source changes, and it adds no `It()`, `Describe()`, `Context()`, or `Wh…
Topology-Aware Scheduling Compatibility	✅ Passed	The authoritative PR diff changes only one ci-operator configuration file and generated Prow job files. It does not add or modify deployment manifests, operator code, or controllers. The added `OPERAT…
Ote Binary Stdout Contract	✅ Passed	PASS. The reviewed range changes only four YAML CI/job files; it adds the OTE image build command and invokes `/usr/local/bin/e2e.test`, but it changes no Go source, Dockerfile, or suite setup code. T…
No-Weak-Crypto	✅ Passed	PASS: The PR changes only four YAML CI configuration/generated ProwJob files. The added lines define images, workflows, jobs, secret mounts, and release labels; they do not introduce MD5, SHA1, DES, 3…
Container-Privileges	✅ Passed	PASS. The PR changes one ci-operator config and generated Prow job files. The changed YAML contains no `privileged: true`, `hostPID`, `hostNetwork`, `hostIPC`, `SYS_ADMIN`, `allowPrivilegeEscalation: …
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds CI/Prow configuration and generated job definitions, not logging code. The added reporter template emits only job status, job name, and the Prow log URL; it contains no password, token, AP…

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

The PR adds three ROSA Ginkgo e2e jobs through rosa-cluster-lease-e2e-workflow. That workflow runs rosa-operator-e2e; its command logs into the external OCM service with ocm login --url "${OCM_LOGIN_ENV}" and then runs ocm backplane login. The PR therefore activates a test path that requires an external API, which violates the disconnected-network condition. No hardcoded IPv4 literal is present in the added config.

Resolution

IPv6 and disconnected network compatibility notice: This test may contain IPv4 assumptions or external connectivity requirements that will fail in IPv6-only disconnected environments. Please verify your test works on IPv6 by running an additional CI job: For parallel tests: /payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ipi-ovn-ipv6 For serial tests (test name contains [Serial]): /payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ipi-serial-ovn-ipv6 If the test cannot run without the external OCM service, add [Skipped:Disconnected] to the test name so disconnected clusters skip it.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

_{Comment @coderabbitai help to get the list of available commands.}

dustman9000 · 2026-09-17T20:13:01Z

/pj-rehearse pull-ci-openshift-osd-metrics-exporter-main-rosa-sts-e2e

openshift-merge-bot · 2026-09-17T20:14:41Z

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

dustman9000 · 2026-09-17T21:11:23Z

/pj-rehearse pull-ci-openshift-osd-metrics-exporter-main-rosa-sts-e2e

openshift-merge-bot · 2026-09-17T21:12:10Z

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

dustman9000 · 2026-09-17T21:16:09Z

/pj-rehearse pull-ci-openshift-osd-metrics-exporter-main-rosa-sts-e2e

openshift-merge-bot · 2026-09-17T21:16:12Z

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Add OCM_ENV and LEASE_ENV env vars to rosa-sts-e2e tests: - rosa-sts-e2e: LEASE_ENV=staging, OCM_ENV=stage - rosa-sts-e2e-promotion-int: OCM_ENV=int - rosa-sts-e2e-promotion-stage: OCM_ENV=stage Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

dustman9000 · 2026-09-17T22:07:07Z

/pj-rehearse pull-ci-openshift-osd-metrics-exporter-main-rosa-sts-e2e

openshift-merge-bot · 2026-09-17T22:07:09Z

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-09-17T22:09:37Z

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-osd-metrics-exporter-main-rosa-sts-e2e	openshift/osd-metrics-exporter	presubmit	Presubmit changed
pull-ci-openshift-osd-metrics-exporter-main-coverage	openshift/osd-metrics-exporter	presubmit	Ci-operator config changed
pull-ci-openshift-osd-metrics-exporter-main-e2e-binary-build-success	openshift/osd-metrics-exporter	presubmit	Ci-operator config changed
pull-ci-openshift-osd-metrics-exporter-main-images	openshift/osd-metrics-exporter	presubmit	Ci-operator config changed
pull-ci-openshift-osd-metrics-exporter-main-lint	openshift/osd-metrics-exporter	presubmit	Ci-operator config changed
pull-ci-openshift-osd-metrics-exporter-main-test	openshift/osd-metrics-exporter	presubmit	Ci-operator config changed
pull-ci-openshift-osd-metrics-exporter-main-validate	openshift/osd-metrics-exporter	presubmit	Ci-operator config changed
periodic-ci-openshift-osd-metrics-exporter-main-rosa-sts-e2e-promotion-int	N/A	periodic	Periodic changed
periodic-ci-openshift-osd-metrics-exporter-main-rosa-sts-e2e-promotion-stage	N/A	periodic	Periodic changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

dustman9000 · 2026-09-17T22:46:02Z

/lgtm
/approve
/pj-rehearse ack

openshift-merge-bot · 2026-09-17T22:46:05Z

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-09-17T22:46:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/osd-metrics-exporter/OWNERS~~ [dustman9000]
~~ci-operator/jobs/openshift/osd-metrics-exporter/OWNERS~~ [dustman9000]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-09-17T22:59:43Z

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot requested review from nephomaniac and tnierman September 17, 2026 20:09

redhat-chai-bot force-pushed the ome-prow-e2e-onboarding branch from f1c5c45 to bdde0c8 Compare September 17, 2026 21:10

redhat-chai-bot force-pushed the ome-prow-e2e-onboarding branch from bdde0c8 to 5d3e8b3 Compare September 17, 2026 22:05

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 17, 2026

openshift-ci Bot assigned dustman9000 Sep 17, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2026

openshift-merge-bot Bot merged commit 278afd4 into openshift:main Sep 17, 2026
18 checks passed

Conversation

redhat-chai-bot commented Sep 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

dustman9000 commented Sep 17, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 17, 2026

Uh oh!

dustman9000 commented Sep 17, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 17, 2026

Uh oh!

dustman9000 commented Sep 17, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 17, 2026

Uh oh!

dustman9000 commented Sep 17, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 17, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 17, 2026

Uh oh!

dustman9000 commented Sep 17, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 17, 2026

Uh oh!

openshift-ci Bot commented Sep 17, 2026

Uh oh!

openshift-ci Bot commented Sep 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

redhat-chai-bot commented Sep 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 17, 2026 •

edited

Loading