Skip to content

Add default slack reporter config for all periodic - #85426

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
afcollins:perfscale-restore-prowconfig
Sep 18, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
afcollins:perfscale-restore-prowconfig

Conversation

@afcollins

@afcollins afcollins commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

ocp-perfscale and ocp-qe-perfscale-ci jobs

Summary by CodeRabbit

  • Adds default Slack notifications for periodic jobs in ocp-perfscale and ocp-qe-perfscale-ci.
  • Sends success, failure, and error results to #ocp-qe-scale-ci-results.
  • Includes the job status and log link in each notification.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: d4f2fd8a-fbac-452c-a8e5-768346c5cb96

📥 Commits

Reviewing files that changed from the base of the PR and between c3655d0 and 79e4ac4.

📒 Files selected for processing (2)
  • core-services/prow/02_config/openshift-eng/ocp-perfscale/_prowconfig.yaml
  • core-services/prow/02_config/openshift-eng/ocp-qe-perfscale-ci/_prowconfig.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

The PR adds Slack reporter configurations for two performance-scale repositories. Periodic job successes, failures, and errors are reported to #ocp-qe-scale-ci-results with status-specific messages and log links.

Changes

Performance-scale Slack reporting

Layer / File(s) Summary
Configure periodic job result reporting
core-services/prow/02_config/openshift-eng/ocp-perfscale/_prowconfig.yaml, core-services/prow/02_config/openshift-eng/ocp-qe-perfscale-ci/_prowconfig.yaml
Both repositories now report periodic job successes, failures, and errors to #ocp-qe-scale-ci-results. Messages include the job name, state, and log URL, with different formatting for successful and non-successful jobs.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 79e4a

No concrete merge-blocking risk is established for these Slack reporting configuration changes.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a default Slack reporter configuration for periodic jobs. It is concise and directly related to the two updated job configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only two Prow YAML configuration files. The added content defines Slack reporter settings and contains no Ginkgo test declarations or test titles. Therefore, the check finds n…
Test Structure And Quality ✅ Passed The reviewed range changes only two _prowconfig.yaml files. The diff adds Slack reporter configuration and changes no Ginkgo tests, test setup, cleanup, waits, or assertions. Therefore, this test-st…
Microshift Test Compatibility ✅ Passed The pull request changes only two Prow YAML configuration files. The diff adds Slack reporter settings and adds no Ginkgo tests, OpenShift API references, namespaces, or MicroShift-related assumptions…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only two Prow YAML configuration files. The additions configure Slack reporting for periodic jobs. The authoritative diff adds no Ginkgo tests, test declarations, node assumpt…
Topology-Aware Scheduling Compatibility ✅ Passed The pull request changes only two Prow YAML configuration files. The added fields configure Slack reporting for periodic jobs; they do not add or modify deployment manifests, operators, controllers, r…
Ote Binary Stdout Contract ✅ Passed PASS. The reviewed range changes only two _prowconfig.yaml files. The additions are declarative Slack reporter settings, with no changes to Go or other executable code, main(), initialization, or …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request changes only two _prowconfig.yaml files. It adds Slack reporter configuration and does not add or modify Ginkgo tests, networking code, image pulls, URLs, or external connecti…
No-Weak-Crypto ✅ Passed The pull request only adds Slack reporter YAML entries and message templates for two periodic job configurations. The added values contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptogra…
Container-Privileges ✅ Passed PASS. The pull request changes only two Prow Slack reporter YAML configurations. The added fields configure channels, report states, periodic job types, and message templates. The diff and final files…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request adds only Slack status messages for periodic jobs. The template emits the fixed channel, job name, status, and .Status.URL; it does not emit logs, credentials, tokens, PII, or…
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 17, 2026
@afcollins

Copy link
Copy Markdown
Contributor Author

/retest

ocp-perfscale and ocp-qe-perfscale-ci jobs

Signed-off-by: Andrew Collins <ancollin@redhat.com>
@afcollins
afcollins force-pushed the perfscale-restore-prowconfig branch from 79e4ac4 to f0d6dc4 Compare September 17, 2026 20:14
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@afcollins: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jtaleric

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2026
@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afcollins, jtaleric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@afcollins: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit b1d6750 into openshift:main Sep 18, 2026
12 checks passed
@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@afcollins: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-eng-ocp-perfscale-_prowconfig.yaml using file core-services/prow/02_config/openshift-eng/ocp-perfscale/_prowconfig.yaml
    • key core-services-prow-02_config-openshift-eng-ocp-qe-perfscale-ci-_prowconfig.yaml using file core-services/prow/02_config/openshift-eng/ocp-qe-perfscale-ci/_prowconfig.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-openshift-eng-ocp-perfscale-_prowconfig.yaml using file core-services/prow/02_config/openshift-eng/ocp-perfscale/_prowconfig.yaml
    • key core-services-prow-02_config-openshift-eng-ocp-qe-perfscale-ci-_prowconfig.yaml using file core-services/prow/02_config/openshift-eng/ocp-qe-perfscale-ci/_prowconfig.yaml
Details

In response to this:

ocp-perfscale and ocp-qe-perfscale-ci jobs

Summary by CodeRabbit

  • Adds default Slack notifications for periodic jobs in ocp-perfscale and ocp-qe-perfscale-ci.
  • Sends success, failure, and error results to #ocp-qe-scale-ci-results.
  • Includes the job status and log link in each notification.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants