Skip to content

chore(console): remove e2e-cypress from 4.23/5.0+ - #85422

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
logonoff:cypress
Sep 17, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
logonoff:cypress

Conversation

@logonoff

@logonoff logonoff commented Sep 17, 2026

Copy link
Copy Markdown
Member

Now that the cypress-based helm tests have been migrated to playwright, there are no more useful cypress tests (the remaining devconsole ones fail 100% of the time and already have playwright equivalents).

Remove the e2e-cypress job as it no longer provides any value during pre-merge validation.

Replaces #82685

Summary by CodeRabbit

The OpenShift console CI configurations for releases 4.23, 5.0, 5.1, 5.2, and the main branch no longer run the e2e-cypress pre-merge job.

The changes remove Cypress credentials, dependencies, commands, resources, timeout, and workflow settings. They also remove the obsolete CYPRESS_INSTALL_BINARY=0 setting from the console test images.

Playwright browser configuration remains in place.

Now that the cypress-based helm tests have been migrated to playwright, there are no more useful cypress tests (the remaining devconsole ones fail 100% of the time and already have playwright equivalents).

Remove the e2e-cypress job as it no longer provides any value during pre-merge validation.
@openshift-ci
openshift-ci Bot requested review from jhadvig and rhamilto September 17, 2026 18:41
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f4fcb000-f8eb-4724-8cb5-78ab57881bb3

📥 Commits

Reviewing files that changed from the base of the PR and between c3655d0 and d9f22c6.

⛔ Files ignored due to path filters (5)
  • ci-operator/jobs/openshift/console/openshift-console-main-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/console/openshift-console-release-4.23-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/console/openshift-console-release-5.0-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/console/openshift-console-release-5.1-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/console/openshift-console-release-5.2-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (5)
  • ci-operator/config/openshift/console/openshift-console-main.yaml
  • ci-operator/config/openshift/console/openshift-console-release-4.23.yaml
  • ci-operator/config/openshift/console/openshift-console-release-5.0.yaml
  • ci-operator/config/openshift/console/openshift-console-release-5.1.yaml
  • ci-operator/config/openshift/console/openshift-console-release-5.2.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The five console CI configurations retain the Playwright browser path, remove the Cypress install override, and remove the optional e2e-cypress test workflow.

Changes

Console CI configuration cleanup

Layer / File(s) Summary
Retain Playwright image configuration
ci-operator/config/openshift/console/openshift-console-*.yaml
The image environments retain PLAYWRIGHT_BROWSERS_PATH and remove CYPRESS_INSTALL_BINARY=0.
Remove optional Cypress workflow
ci-operator/config/openshift/console/openshift-console-*.yaml
The e2e-cypress workflow and its credentials, dependencies, commands, resources, timeouts, and workflow settings are removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: psalajova

Merge Risk: ⚪ Minimal · up to d9f22

The removed Cypress workflow is replaced by retained browser-based e2e coverage configuration in every affected branch. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: removing the e2e-cypress job from console configurations for 4.23 and later releases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only CI configuration and generated Prow job definitions. The diff removes the e2e-cypress workflows and changes five static environment declarations. It adds no Ginkgo test…
Test Structure And Quality ✅ Passed PASS — The pull request changes only CI YAML configuration. It removes the e2e-cypress test jobs and related image environment settings from five config files, and removes the generated presubmit en…
Microshift Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo e2e tests. The authoritative diff changes only YAML CI configuration, removes the e2e-cypress jobs and presubmit entries, and adds only `PLAYWRIGHT_BROWSERS_PAT…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request adds no Ginkgo e2e tests. The authoritative diff changes only CI YAML files, removes the e2e-cypress pipelines and presubmit jobs, and removes CYPRESS_INSTALL_BINARY=0. No added `…
Topology-Aware Scheduling Compatibility ✅ Passed PASS. The pull request changes only ci-operator configuration and generated Prow presubmit files. The diff removes the e2e-cypress test and removes CYPRESS_INSTALL_BINARY=0. It adds no deployment,…
Ote Binary Stdout Contract ✅ Passed PASS. The pull request changes only 10 YAML files. It removes Cypress configuration and generated presubmit jobs. It adds no Go or other binary source code and introduces no stdout, logging, main, or …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only ten YAML CI configuration files. The diff removes the e2e-cypress pipelines and the CYPRESS_INSTALL_BINARY setting, with no added Ginkgo test declarations or ne…
No-Weak-Crypto ✅ Passed The pull request does not introduce weak cryptography or custom cryptographic code. The authoritative diff contains only five added lines, all setting ENV PLAYWRIGHT_BROWSERS_PATH=/opt/playwright; t…
Container-Privileges ✅ Passed The pull request does not add privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation. The only USER root entries are unchanged from the base revision. Th…
No-Sensitive-Data-In-Logs ✅ Passed The pull request introduces no sensitive-data logging. The authoritative diff has only five added lines, all setting PLAYWRIGHT_BROWSERS_PATH=/opt/playwright. The remaining changes delete the `e2e-c…
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@logonoff: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-console-release-5.0-analyze openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.0-backend openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.0-e2e-gcp-console openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.0-e2e-gcp-console-techpreview openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.0-frontend openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.0-images openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.0-okd-scos-images openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.1-analyze openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.1-backend openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.1-e2e-gcp-console openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.1-e2e-gcp-console-techpreview openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.1-frontend openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.1-images openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-4.23-analyze openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-4.23-backend openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-4.23-e2e-gcp-console openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-4.23-e2e-gcp-console-techpreview openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-4.23-frontend openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-4.23-images openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.2-analyze openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.2-backend openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.2-e2e-gcp-console openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.2-e2e-gcp-console-techpreview openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.2-frontend openshift/console presubmit Ci-operator config changed
pull-ci-openshift-console-release-5.2-images openshift/console presubmit Ci-operator config changed

A total of 33 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@logonoff

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@logonoff

Copy link
Copy Markdown
Member Author

/retest

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shahsahil264 shahsahil264 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2026
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, shahsahil264

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff

logonoff commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

The openshift/release PR has to go before the openshift/console PR, so that e2e-cypress doesn't fail on the cypress script not being found.

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@logonoff: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 17, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 9a66900 into openshift:main Sep 17, 2026
17 checks passed
@logonoff
logonoff deleted the cypress branch September 17, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants