Skip to content

SDCICD-2002: Enable jira-lifecycle-plugin for openshift-online repos - #85420

Open
varunraokadaparthi wants to merge 1 commit into
openshift:mainfrom
varunraokadaparthi:SDCICD-2002
Open

varunraokadaparthi wants to merge 1 commit into
openshift:mainfrom
varunraokadaparthi:SDCICD-2002

Conversation

@varunraokadaparthi

@varunraokadaparthi varunraokadaparthi commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Jira: https://redhat.atlassian.net/browse/SDCICD-2002

Enables the Prow jira-lifecycle-plugin for three openshift-online repos so GitHub PRs link to their Jira issues and issue state transitions on validation and merge.

  • openshift-online/argya
  • openshift-online/hp-gitops-manifests
  • openshift-online/hp-gitops-tenants

Changes per repo, under core-services/prow/02_config/openshift-online/<repo>/:

  • _pluginconfig.yaml - register jira-lifecycle-plugin as an external plugin, and add the built-in jira plugin
  • _prowconfig.yaml - add jira/invalid-bug to the tide missingLabels, so an invalid Jira reference blocks the merge

For hp-gitops-manifests the label is added only to the reviewed tide query (main + overlays/prod); the other query is the gitops-automator promotion lane, whose PRs carry no Jira references.

openshift-online/featurecheck is out of scope: it is not onboarded to Prow at all.

🤖 Generated with Claude Code

Enable the Prow jira-lifecycle-plugin for argya, hp-gitops-manifests and
hp-gitops-tenants so GitHub PRs are linked to their Jira issues and issue
state is transitioned as PRs are validated and merged. 31 of the 56
openshift-online repos already register this plugin; these three did not.

For each repo:

  _pluginconfig.yaml
    - register jira-lifecycle-plugin as an external plugin, on the
      issue_comment, pull_request and pull_request_review events
    - add the built-in jira plugin to the plugins list

  _prowconfig.yaml
    - add jira/invalid-bug to the tide query missingLabels

The external plugin only detects and labels; the tide missingLabels entry
is what blocks the merge. 30 of the 31 already-enabled repos pair them
this way.

For hp-gitops-manifests the label is added only to the reviewed tide
query (main + overlays/prod, gated on approved + lgtm). The other query
is the gitops-automator promotion lane for the overlays/* branches, which
merges without approval labels and whose PRs carry no Jira references.

Assisted-by: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@varunraokadaparthi: This pull request references SDCICD-2002 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Jira: https://redhat.atlassian.net/browse/SDCICD-2002

Enables the Prow jira-lifecycle-plugin for three openshift-online repositories so GitHub PRs are linked to their Jira issues and issue state is transitioned automatically as PRs are validated and merged.

31 of the 56 openshift-online repos configured here already register this plugin. These three did not:

  • openshift-online/argya
  • openshift-online/hp-gitops-manifests
  • openshift-online/hp-gitops-tenants

Changes

Per repo, under core-services/prow/02_config/openshift-online/<repo>/:

_pluginconfig.yaml

  • Register jira-lifecycle-plugin as an external plugin, on the issue_comment, pull_request and pull_request_review events
  • Add the built-in jira plugin to the plugins list

_prowconfig.yaml

  • Add jira/invalid-bug to the tide query missingLabels

The external plugin only detects and labels; the tide missingLabels entry is what actually blocks the merge. 30 of the 31 already-enabled repos pair them this way.

For hp-gitops-manifests the label is added only to the reviewed tide query (main + overlays/prod, gated on approved + lgtm). The other query is the gitops-automator promotion lane for the overlays/* branches, which merges without approval labels and whose PRs carry no Jira references.

Validation

make prow-config runs clean and does not reformat these files, so the sharded layout and ordering are already canonical.

make checkconfig could not be run locally — it fails with stat /release/core-services/prow/02_config: invalid argument, a podman volume-mount issue reproducible on a clean tree with no changes applied. Leaving that to CI.

Note for reviewers

No openshift-online repo has an entry in core-services/jira-lifecycle-plugin/config.yaml, so these repos inherit the default branch configuration. For branch main that includes target_version: 5.1.0, which is OCP-specific. validate_by_default is unset, so validation only runs on PRs whose title already contains a Jira key and PRs without one are unaffected — but an openshift-online entry with an appropriate target_version / valid_states may be worth a follow-up.

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from RH-tj and fishi0x01 September 17, 2026 17:41
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a2c9572e-b10b-4252-8768-bd179eb174ba

📥 Commits

Reviewing files that changed from the base of the PR and between c3655d0 and 022d6d5.

📒 Files selected for processing (6)
  • core-services/prow/02_config/openshift-online/argya/_pluginconfig.yaml
  • core-services/prow/02_config/openshift-online/argya/_prowconfig.yaml
  • core-services/prow/02_config/openshift-online/hp-gitops-manifests/_pluginconfig.yaml
  • core-services/prow/02_config/openshift-online/hp-gitops-manifests/_prowconfig.yaml
  • core-services/prow/02_config/openshift-online/hp-gitops-tenants/_pluginconfig.yaml
  • core-services/prow/02_config/openshift-online/hp-gitops-tenants/_prowconfig.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The change configures Jira lifecycle events for three OpenShift Online repositories. It enables the Jira plugin and adds jira/invalid-bug to each repository’s Tide missing-label conditions.

Changes

Jira Prow integration

Layer / File(s) Summary
Jira lifecycle plugin configuration
core-services/prow/02_config/openshift-online/{argya,hp-gitops-manifests,hp-gitops-tenants}/_pluginconfig.yaml
Each repository adds jira-lifecycle-plugin handling for issue comments, pull requests, and pull request reviews. Each repository enables the jira plugin.
Jira Tide label handling
core-services/prow/02_config/openshift-online/{argya,hp-gitops-manifests,hp-gitops-tenants}/_prowconfig.yaml
Each repository adds jira/invalid-bug to the Tide query’s missing-label conditions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 022d6

The PR adds the requested Jira plugin and Tide configuration, with no verified merge-blocking issue identified.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only six YAML Prow configuration files. The added lines register jira-lifecycle-plugin, enable jira, and add jira/invalid-bug to Tide missingLabels. No Ginkgo test dec…
Test Structure And Quality ✅ Passed The pull request changes only six YAML Prow configuration files. It adds external plugin registrations, the built-in jira plugin, and Tide missingLabels entries. It adds no Ginkgo tests or test op…
Microshift Test Compatibility ✅ Passed The pull request changes only six Prow YAML configuration files. The diff adds Jira plugin registration and Tide missing-label entries; it adds no Ginkgo e2e tests or test code that references MicroSh…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only six Prow YAML configuration files. The reviewed diff adds Jira plugin registrations and Tide labels, and adds no Ginkgo tests or other test code. Therefore, the SNO…
Topology-Aware Scheduling Compatibility ✅ Passed The pull request changes only six Prow YAML configuration files. The diff adds the jira-lifecycle-plugin, the built-in jira plugin, and jira/invalid-bug Tide labels. It adds no deployment manife…
Ote Binary Stdout Contract ✅ Passed PASS. The pull request changes only six YAML configuration files. The diff adds Prow plugin registrations and Tide labels. It does not change Go binaries or process-level code such as main(), init(), …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request changes only six Prow YAML configuration files. The diff adds Jira plugin configuration and Tide labels; it adds no Ginkgo tests, test bodies, IPv4 literals, or public-network c…
No-Weak-Crypto ✅ Passed The pull request changes only six Prow YAML configuration files. The added lines register jira-lifecycle-plugin, enable jira, and add the jira/invalid-bug label. No MD5, SHA1, DES, RC4, 3DES, Bl…
Container-Privileges ✅ Passed PASS. The pull request changes only six Prow YAML configuration files. Added lines register jira-lifecycle-plugin, enable jira, and add jira/invalid-bug. No changed line introduces privileged,…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request changes only six YAML configuration files, with 24 added lines. The additions register an existing internal jira-lifecycle-plugin endpoint, enable the jira plugin, and add `…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: enabling jira-lifecycle-plugin for openshift-online repositories.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: varunraokadaparthi
Once this PR has been reviewed and has the lgtm label, please assign ritmun for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 17, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@varunraokadaparthi: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@ritmun

ritmun commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@varunraokadaparthi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants