Skip to content

NO-JIRA: upkeep: remove gcp-gracefulshutdown lanes - #85419

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
eggfoobar:remove-unused-lane
Sep 17, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
eggfoobar:remove-unused-lane

Conversation

@eggfoobar

@eggfoobar eggfoobar commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

GNS lane is no longer needed, it was part of an initiative that is no longer valid, removing

Summary by CodeRabbit

Removed the unused GCP graceful-shutdown CI lane from OpenShift nightly release configurations for versions 4.14 through 5.1.

Deleted the related step registry configuration, workflow, metadata, scripts, and ownership files.

GNS lane is no longer needed, it was part of an initiative that is no longer valid, removing

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@eggfoobar: This pull request explicitly references no jira issue.

Details

In response to this:

GNS lane is no longer needed, it was part of an initiative that is no longer valid, removing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: cfafffe7-fa1e-43aa-93c7-c0ad4b2eafe7

📥 Commits

Reviewing files that changed from the base of the PR and between c3655d0 and 2753f79.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (19)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.14.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.15.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.16.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.17.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.18.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.1.yaml
  • ci-operator/step-registry/ipi/conf/graceful-shutdown/OWNERS
  • ci-operator/step-registry/ipi/conf/graceful-shutdown/ipi-conf-graceful-shutdown-commands.sh
  • ci-operator/step-registry/ipi/conf/graceful-shutdown/ipi-conf-graceful-shutdown-ref.metadata.json
  • ci-operator/step-registry/ipi/conf/graceful-shutdown/ipi-conf-graceful-shutdown-ref.yaml
  • ci-operator/step-registry/openshift/e2e/gcp/graceful-shutdown/OWNERS
  • ci-operator/step-registry/openshift/e2e/gcp/graceful-shutdown/openshift-e2e-gcp-graceful-shutdown-workflow.metadata.json
  • ci-operator/step-registry/openshift/e2e/gcp/graceful-shutdown/openshift-e2e-gcp-graceful-shutdown-workflow.yaml
💤 Files with no reviewable changes (19)
  • ci-operator/step-registry/ipi/conf/graceful-shutdown/ipi-conf-graceful-shutdown-ref.metadata.json
  • ci-operator/step-registry/openshift/e2e/gcp/graceful-shutdown/OWNERS
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
  • ci-operator/step-registry/ipi/conf/graceful-shutdown/OWNERS
  • ci-operator/step-registry/ipi/conf/graceful-shutdown/ipi-conf-graceful-shutdown-commands.sh
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
  • ci-operator/step-registry/openshift/e2e/gcp/graceful-shutdown/openshift-e2e-gcp-graceful-shutdown-workflow.metadata.json
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.19.yaml
  • ci-operator/step-registry/openshift/e2e/gcp/graceful-shutdown/openshift-e2e-gcp-graceful-shutdown-workflow.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.21.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.14.yaml
  • ci-operator/step-registry/ipi/conf/graceful-shutdown/ipi-conf-graceful-shutdown-ref.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.18.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.20.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.17.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.15.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.16.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.23.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.1.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The change removes the graceful-shutdown step and GCP workflow. It removes scheduled references from nightly release configurations for versions 4.14 through 5.1. The 4.15 configuration adds an AWS shared-VPC PHZ TechPreview test.

Changes

Graceful-shutdown test removal

Layer / File(s) Summary
Remove graceful-shutdown registry components
ci-operator/step-registry/ipi/conf/graceful-shutdown/*, ci-operator/step-registry/openshift/e2e/gcp/graceful-shutdown/*
The graceful-shutdown command, registry definition, workflow, metadata, and ownership files were deleted.
Update nightly release schedules
ci-operator/config/openshift/release/openshift-release-main__nightly-4.*.yaml, ci-operator/config/openshift/release/openshift-release-main__nightly-5.*.yaml
The scheduled GCP graceful-shutdown test was removed from nightly configurations. The 4.15 configuration adds the AWS shared-VPC PHZ TechPreview test.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2753f

The supplied change removes obsolete CI configuration, with no verified merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the unused GCP graceful-shutdown lanes and related configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request removes graceful-shutdown CI configurations, workflows, and generated Prow jobs. The authoritative diff adds no Ginkgo title constructs such as It(), Describe(), Context(), or `…
Test Structure And Quality ✅ Passed PASS — the pull request does not add or modify Ginkgo test code. The authoritative diff changes release YAML, generated periodic-job YAML, ownership/metadata files, and deletes graceful-shutdown shell…
Microshift Test Compatibility ✅ Passed The check is not applicable. The pull request adds no Ginkgo test source or declarations. The authoritative diff only removes graceful-shutdown release jobs and step-registry YAML, JSON, and shell fil…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS — The pull request adds no Ginkgo e2e test code. The authoritative diff contains no added .go files or added It(), Describe(), Context(), or When() declarations. It removes the `e2e-gcp…
Topology-Aware Scheduling Compatibility ✅ Passed The pull request only removes CI release test entries, generated Prow periodic jobs, and graceful-shutdown step-registry files. It adds or modifies no deployment manifests, operator code, or controlle…
Ote Binary Stdout Contract ✅ Passed The pull request changes only release/periodic YAML configuration and deletes graceful-shutdown registry files. The authoritative diff adds no executable source and contains no process-level stdout ca…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo e2e tests. The authoritative diff only removes graceful-shutdown release entries, generated jobs, and step-registry files. Job-name comparison shows 12 graceful-s…
No-Weak-Crypto ✅ Passed PASS. The reviewed diff removes graceful-shutdown configuration and workflow files. The only added content is generated periodics configuration, and added-line searches found no MD5, SHA1, DES, 3DES, …
Container-Privileges ✅ Passed PASS: The pull request introduces no explicit privileged container settings. The release YAML changes only delete the GCP graceful-shutdown tests. The graceful-shutdown step and workflow files are del…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request adds no logging code or log statements. The authoritative diff contains only release/job configuration additions and removals, plus deletion of graceful-shutdown scripts and wor…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from smg247 and sosiouxme September 17, 2026 17:18
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 17, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@eggfoobar: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@neisw

neisw commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2026
@jaypoulz

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2026
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, jaypoulz, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eggfoobar

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 6fe37b5 into openshift:main Sep 17, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants