Skip to content

WIP: Add periodic jira-refresh for monitoring repos on release branches - #85417

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:periodic-jira-refresh-release-monitoring
Open

redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:periodic-jira-refresh-release-monitoring

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Adds a daily periodic job (08:00 UTC) that posts /jira refresh on open PRs in monitoring repos targeting release-* branches with jira/invalid-bug + lgtm + approved labels (excluding held PRs).

This is a fallback in case openshift/release-controller#817 misses re-evaluating dependent bug state changes.

Follows the same commenter pattern as the existing periodic-jira-refresh-main/-master entries.

Refs: OCPCRT-640

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: This pull request references OCPCRT-640 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

Add a daily periodic job that posts /jira refresh on open PRs targeting release-* branches in OpenShift monitoring repos when those PRs have jira/invalid-bug + lgtm + approved labels.

This addresses OCPCRT-640 — when a dependent Jira bug's status changes (e.g. moves to VERIFIED or CLOSED), PRs on release branches that were previously marked jira/invalid-bug are not automatically re-evaluated. This job triggers the jira-lifecycle-plugin to re-check validity daily at 08:00 UTC.

Details

  • Job name: periodic-jira-refresh-release-monitoring
  • Schedule: Daily at 08:00 UTC
  • Tool: Existing commenter (quay.io/openshift/ci:ci_commenter_latest)
  • Query filters:
  • is:pr state:open base:release-
  • label:jira/invalid-bug label:lgtm label:approved
  • -label:do-not-merge/hold
  • Scoped to 9 monitoring repos

Repos covered

  • openshift/prometheus-alertmanager
  • openshift/cluster-monitoring-operator
  • openshift/kube-state-metrics
  • openshift/kubernetes-metrics-server
  • openshift/node_exporter
  • openshift/prom-label-proxy
  • openshift/prometheus
  • openshift/prometheus-operator
  • openshift/thanos

How it works

The commenter tool posts /jira refresh on matching PRs. The jira-lifecycle-plugin (event-driven) sees the comment and re-validates the linked Jira bug against current dependent_bug_states rules. If the dependent bug now meets criteria, the plugin removes jira/invalid-bug and adds jira/valid-bug.

This follows the same pattern as the existing periodic-jira-refresh-main and periodic-jira-refresh-master entries.


AI-generated. Review for accuracy.

@machine424 requested via Chai Bot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@machine424

Copy link
Copy Markdown
Contributor

/retitle WIP: Add periodic jira-refresh for monitoring repos on release branches

@openshift-ci openshift-ci Bot changed the title OCPCRT-640: Add periodic jira-refresh for monitoring repos on release branches WIP: Add periodic jira-refresh for monitoring repos on release branches Sep 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Summary

Add a daily periodic job that posts /jira refresh on open PRs targeting release-* branches in OpenShift monitoring repos when those PRs have jira/invalid-bug + lgtm + approved labels.

This addresses OCPCRT-640 — when a dependent Jira bug's status changes (e.g. moves to VERIFIED or CLOSED), PRs on release branches that were previously marked jira/invalid-bug are not automatically re-evaluated. This job triggers the jira-lifecycle-plugin to re-check validity daily at 08:00 UTC.

Details

  • Job name: periodic-jira-refresh-release-monitoring
  • Schedule: Daily at 08:00 UTC
  • Tool: Existing commenter (quay.io/openshift/ci:ci_commenter_latest)
  • Query filters:
  • is:pr state:open base:release-
  • label:jira/invalid-bug label:lgtm label:approved
  • -label:do-not-merge/hold
  • Scoped to 9 monitoring repos

Repos covered

  • openshift/prometheus-alertmanager
  • openshift/cluster-monitoring-operator
  • openshift/kube-state-metrics
  • openshift/kubernetes-metrics-server
  • openshift/node_exporter
  • openshift/prom-label-proxy
  • openshift/prometheus
  • openshift/prometheus-operator
  • openshift/thanos

How it works

The commenter tool posts /jira refresh on matching PRs. The jira-lifecycle-plugin (event-driven) sees the comment and re-validates the linked Jira bug against current dependent_bug_states rules. If the dependent bug now meets criteria, the plugin removes jira/invalid-bug and adds jira/valid-bug.

This follows the same pattern as the existing periodic-jira-refresh-main and periodic-jira-refresh-master entries.


AI-generated. Review for accuracy.

@machine424 requested via Chai Bot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2026
@openshift-ci
openshift-ci Bot requested review from jmguzik and smg247 September 17, 2026 16:51
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 17, 2026
Comment thread ci-operator/jobs/infra-periodics.yaml Outdated
- name: github-app-credentials
secret:
secretName: openshift-prow-github-app
- agent: kubernetes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the appropriate place?
This is a monitoring team cron.
How about https://github.com/redhat-chai-bot/openshift_release/tree/024d1fcef992fafcdd88578e5f1ab4712d146dc1/ci-operator/jobs/openshift/cluster-monitoring-operator? could they contain manually added crons?

you'd need to change ci.openshift.io/role: infra etc

Comment thread ci-operator/jobs/infra-periodics.yaml Outdated
valueFrom:
secretKeyRef:
key: appid
name: openshift-prow-github-app

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would the cron be able to access this?

@redhat-chai-bot
redhat-chai-bot force-pushed the periodic-jira-refresh-release-monitoring branch from 024d1fc to 24e7fd8 Compare September 17, 2026 17:26
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2026
… branches

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@redhat-chai-bot
redhat-chai-bot force-pushed the periodic-jira-refresh-release-monitoring branch from 24e7fd8 to fbfa53f Compare September 17, 2026 17:45
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants