Skip to content

fix: fail closed edge CI monitor Slack notifications - #85405

Open
redhat-chai-bot wants to merge 2 commits into
openshift:mainfrom
redhat-chai-bot:edge-ocp-monitor-notifier-fail-closed
Open

redhat-chai-bot wants to merge 2 commits into
openshift:mainfrom
redhat-chai-bot:edge-ocp-monitor-notifier-fail-closed

Conversation

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

What

The Edge OCP CI Monitor Slack step could treat an empty failing-jobs.txt as proof that analysis completed. When report generation or extraction failed, this allowed a green No failing jobs found message and a broken dashboard link.

Changes

  • Track monitor start and mark the dashboard ready only after validating a newly generated, complete report.
  • Validate both blocking and informing extraction sections before atomically publishing the jobs file and its data-ready marker.
  • Require monitor completion, report readiness, data readiness, and valid extracted data before emitting result messages.
  • Send a warning with the Prow logs link only when data or the dashboard is unavailable; do not emit a broken dashboard link.
  • Preserve the existing failure-count summaries for valid blocking and informing data.

Validation

  • Focused dry-run matrix: 9/9 scenarios passed, including missing or incomplete reports, missing sections, extraction errors, valid empty data, blocking or informing data, and stale zero-byte data.
  • bash -n passed for both changed scripts.
  • Targeted shellcheck -S warning passed for both changed scripts.
  • ./hack/validate-registry-commands.sh . passed.
  • git diff --check passed.

make validate-step-registry remains blocked by an existing resolver/Makefile incompatibility: the resolver rejects the unchanged --prow-config option, and the failure reproduces on origin/main. No generated files are changed.


AI-generated. Review for accuracy.

@vimauro requested via Chai Bot

Require complete extracted job sections and a separate data-ready marker before Slack evaluates monitor results.
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 244c6bfe-1326-41fd-b363-b139b7d43164

📥 Commits

Reviewing files that changed from the base of the PR and between 9614a66 and 89af2ef.

📒 Files selected for processing (2)
  • ci-operator/step-registry/openshift/edge-tooling/ci-monitor/openshift-edge-tooling-ci-monitor-commands.sh
  • ci-operator/step-registry/openshift/edge-tooling/ci-monitor/send-slack/openshift-edge-tooling-ci-monitor-send-slack-commands.sh

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign suleymanakbas91 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-eng-edge-tooling-main-ocp-ci-monitor N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@vimauro

vimauro commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2026
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/core-valid 89af2ef link true /test core-valid
ci/prow/agent-model-policy 89af2ef link true /test agent-model-policy

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants