Skip to content

feat(clusterpool): add obs-logging pool for 4.23 candidate - #85403

Open
jcantrill wants to merge 1 commit into
openshift:mainfrom
jcantrill:423clusterpool
Open

jcantrill wants to merge 1 commit into
openshift:mainfrom
jcantrill:423clusterpool

Conversation

@jcantrill

@jcantrill jcantrill commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

cc @xperimental @cahartma @vparfonov @Clee2691

Summary by CodeRabbit

  • Adds the OpenShift 4.23 candidate release image configuration.
  • Adds an obs-logging Hive ClusterPool for two AMD64 AWS clusters in us-east-1.
  • Configures installation credentials, secrets, pool limits, pull secret, timeouts, and skipped machine pools.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0539abbb-10f2-4956-a7f9-32be52a196bf

📥 Commits

Reviewing files that changed from the base of the PR and between 9614a66 and 105f813.

📒 Files selected for processing (2)
  • clusters/hosted-mgmt/hive/pools/ocp-release-4.23.0-ec.0-multi-for-4.23.0-0-to-4.24.0-0_clusterimageset.yaml
  • clusters/hosted-mgmt/hive/pools/openshift-observability/obs-logging-ocp-4-23-amd64-aws-us-east-1_clusterpool.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


Walkthrough

The pull request adds an OpenShift 4.23 multi-architecture ClusterImageSet and an AWS ClusterPool for two observability clusters in us-east-1.

Changes

OpenShift 4.23 release and pool

Layer / File(s) Summary
OpenShift 4.23 release image metadata
clusters/hosted-mgmt/hive/pools/ocp-release-4.23.0-ec.0-multi-for-4.23.0-0-to-4.24.0-0_clusterimageset.yaml
Adds a multi-architecture ClusterImageSet with 4-dev-preview annotations, version bounds from 4.23.0-0 through 4.24.0-0, and a release image reference.
Observability AWS ClusterPool
clusters/hosted-mgmt/hive/pools/openshift-observability/obs-logging-ocp-4-23-amd64-aws-us-east-1_clusterpool.yaml
Adds an AMD64 AWS ClusterPool for us-east-1 with release, credential, install, sizing, timeout, and initial status configuration.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 105f8

The new release image metadata and observability pool configuration have no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding the obs-logging ClusterPool for an OpenShift 4.23 candidate release.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request adds only two YAML resources: one ClusterImageSet and one ClusterPool. The authoritative diff contains no Ginkgo or other test declarations, no test titles, and no dynamic title expre…
Test Structure And Quality ✅ Passed PASS: The pull request changes only two YAML resource declarations: one ClusterImageSet and one ClusterPool. The review-scoped diff contains no Ginkgo test code, test blocks, assertions, waits, or set…
Microshift Test Compatibility ✅ Passed PASS: The pull request adds only two YAML Hive manifests: one ClusterImageSet and one ClusterPool. The authoritative diff adds no Ginkgo tests or test constructs such as It(), Describe(), Context(), o…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request adds only two YAML resources: a Hive ClusterImageSet and a Hive ClusterPool. The authoritative diff contains no new Ginkgo tests or other test files with It(), Describe(), Context(), …
Topology-Aware Scheduling Compatibility ✅ Passed The pull request adds only a Hive ClusterImageSet and a Hive ClusterPool. The added fields define the release image, AWS platform, credentials, pool size, and install settings. They do not add dep…
Ote Binary Stdout Contract ✅ Passed PASS. The pull request adds only two YAML resource declarations: one ClusterImageSet and one ClusterPool. The authoritative diff contains no executable source, OTE entry points, suite setup, logging c…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The pull request adds two Hive YAML resources only: a ClusterImageSet and a ClusterPool. The reviewed diff adds no Ginkgo tests or test code, so the IPv4 and external-connectivity test condition…
No-Weak-Crypto ✅ Passed PASS: The pull request adds only two declarative YAML resources. The added content contains no MD5, SHA1, DES, RC4, 3DES, Blowfish, or ECB configuration, custom crypto implementation, or secret/token …
Container-Privileges ✅ Passed The pull request adds only a Hive ClusterImageSet and ClusterPool. The added manifests contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, `secur…
No-Sensitive-Data-In-Logs ✅ Passed The pull request adds only two Hive YAML resources. Neither resource configures logging or emits log content. The ClusterPool contains only references to existing secrets and a base domain; it does no…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jcantrill: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@jcantrill

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant