feat(clusterpool): add obs-logging pool for 4.22

[jcantrill]

cc @xperimental @cahartma @vparfonov

Summary by CodeRabbit

Adds an OpenShift 4.22 obs-logging ClusterPool for CI infrastructure.

• Supports two AMD64 AWS clusters in us-east-1 with release 4.22.14.
• Sets the maximum pool size to 10.
• Configures one installation attempt and a 20-minute resume timeout.
• Starts with no ready, active, or standby clusters.
• Sets the OpenShift 4.16, 4.17, and 4.18 obs-logging pool sizes to zero.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6fa37145-c2cc-4d77-be79-ddda6900f3bd

📥 Commits

Reviewing files that changed from the base of the PR and between 2afe1f8 and 37dcd1f.

📒 Files selected for processing (3)

• clusters/hosted-mgmt/hive/pools/openshift-observability/obs-logging-ocp-4-16-0-amd64-aws-us-east-1_clusterpool.yaml
• clusters/hosted-mgmt/hive/pools/openshift-observability/obs-logging-ocp-4-17-0-amd64-aws-us-east-1_clusterpool.yaml
• clusters/hosted-mgmt/hive/pools/openshift-observability/obs-logging-ocp-4-18-amd64-aws-us-east-1_clusterpool.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

Adds an OCP 4.22 Hive ClusterPool for AMD64 AWS clusters in us-east-1. Sets its maximum size to 10. Sets the default size of the OCP 4.16, 4.17, and 4.18 pools to zero.

Changes

Observability ClusterPools

Layer / File(s)	Summary
Add OCP 4.22 ClusterPool clusters/hosted-mgmt/hive/pools/openshift-observability/obs-logging-ocp-4-22-amd64-aws-us-east-1_clusterpool.yaml	Defines the OCP 4.22 AWS ClusterPool with release, credential, install configuration, sizing, retry, timeout, hibernation, and initial status settings.
Disable older default pools clusters/hosted-mgmt/hive/pools/openshift-observability/obs-logging-ocp-4-{16-0,17-0,18}-amd64-aws-us-east-1_clusterpool.yaml	Changes the default size from 1, 1, and 2 to 0 for the OCP 4.16, 4.17, and 4.18 ClusterPools.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 37dcd

The new observability pool is configured consistently, while older pools are intentionally disabled by default. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding the obs-logging ClusterPool for OpenShift 4.22.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The pull request changes four YAML ClusterPool manifests only. The diff contains no Ginkgo test declarations or test titles such as It(), Describe(), Context(), or When(). Therefore, i…
Test Structure And Quality	✅ Passed	The pull request changes only four YAML ClusterPool files. The authoritative diff contains no Ginkgo test files, test blocks, cluster operations, waits, or assertions. Therefore, the stated Ginkgo tes…
Microshift Test Compatibility	✅ Passed	PASS: The pull request changes only Hive ClusterPool YAML files. It adds no Ginkgo tests or test cases, and it introduces no MicroShift API or feature references covered by this check.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only four Hive ClusterPool YAML files. The diff adds no Ginkgo tests or other test code, so the Single Node OpenShift test-compatibility check is not applicable. The changes o…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS — The PR changes only four Hive ClusterPool YAML objects. The added 4.22 object defines release, AWS, pool size, and secret references; it does not define pod affinity, topology spread, node se…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request changes only four YAML ClusterPool manifests. The diff adds one manifest and changes three size fields. It contains no OTE binary code, suite setup, logging calls, or stdout w…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS. The pull request changes only four YAML ClusterPool files. The reviewed diff adds no Ginkgo tests or test code, and it contains no IPv4 test assumptions or external-connectivity operations. The …
No-Weak-Crypto	✅ Passed	PASS: The pull request changes only four YAML ClusterPool manifests. The added manifest contains configuration and secret references, but no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptograp…
Container-Privileges	✅ Passed	The pull request changes four Hive ClusterPool YAML manifests. The new 4.22 manifest defines pool sizing, AWS references, and skipMachinePools; the other changes only set size to zero. None of t…
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request changes only four Hive ClusterPool YAML files. It adds configuration and secret references, not logging code or log messages. The new file contains no passwords, tokens, API key…

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

@jcantrill: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

[jcantrill]

/retest

[cahartma]

If you can scale the 4.16, 4.17, and 4.18 size to zero. The rest looks good. lmk if you want me to take care of the others.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@jcantrill: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[jcantrill]

/label tide/merge-method-squash

[jcantrill]

/retest

[jcantrill]

/retest-required

[openshift-ci]

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[vparfonov]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• clusters/hosted-mgmt/hive/pools/openshift-observability/OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment