HYPERFLEET-1663 - fix: export OIDC_ISSUER_MODE for e2e cleanup manifest

[Mischulee]

• Ticket: HYPERFLEET-1663
• openshift-hyperfleet-e2e-setup's post-install helmfile list call invoked helmfile directly without OIDC_ISSUER_MODE, which install-hyperfleet only computes internally via make and never exports back to the shell
• Set OIDC_ISSUER_MODE=mock explicitly, matching e2e-gcp's default

Test Plan

• Reproduced the failure locally: helmfile list without OIDC_ISSUER_MODE fails with the exact error from the tier0 job logs
• Verified the fix: same command with OIDC_ISSUER_MODE=mock succeeds and returns valid release JSON

Summary by CodeRabbit

• Sets OIDC_ISSUER_MODE="mock" for the post-install helmfile list command in OpenShift HyperFleet end-to-end CI.
• Allows the command to return valid release JSON for the cleanup manifest.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f7acd29d-08ec-452b-802d-9cb1c785ff31

📥 Commits

Reviewing files that changed from the base of the PR and between f5df747 and f5928e0.

📒 Files selected for processing (1)

• ci-operator/step-registry/openshift-hyperfleet/e2e/setup/openshift-hyperfleet-e2e-setup-commands.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

Walkthrough

The Helmfile release-list command now sets OIDC_ISSUER_MODE="mock" while preserving its existing arguments.

Changes

OIDC issuer mode

Layer / File(s)	Summary
Helmfile release-list environment ci-operator/step-registry/openshift-hyperfleet/e2e/setup/openshift-hyperfleet-e2e-setup-commands.sh	The command adds OIDC_ISSUER_MODE="mock". Existing namespace, environment, output path, and JSON format arguments remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to f5928

This change enables the cleanup manifest command to produce valid release JSON without introducing a current merge-blocking risk.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the fix: exporting OIDC_ISSUER_MODE for the Hyperfleet end-to-end cleanup manifest.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only a shell setup command. The added lines set OIDC_ISSUER_MODE="mock" for helmfile list; they do not add or modify any Ginkgo test title. No It(), Describe(), …
Test Structure And Quality	✅ Passed	PASS: The pull request changes only one .sh setup script, adding OIDC_ISSUER_MODE="mock" to a helmfile list command. It adds or modifies no Ginkgo It blocks or test code, so the listed test-st…
Microshift Test Compatibility	✅ Passed	The pull request changes only openshift-hyperfleet-e2e-setup-commands.sh. The two added lines set OIDC_ISSUER_MODE="mock" for a helmfile list command. The diff adds no Ginkgo tests, OpenShift AP…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only one shell script and adds OIDC_ISSUER_MODE="mock" to a helmfile list command. The authoritative patch adds no Ginkgo tests or test declarations such as It(), …
Topology-Aware Scheduling Compatibility	✅ Passed	PASS. The pull request changes one shell script only. It adds OIDC_ISSUER_MODE="mock" to a helmfile list command that writes cleanup JSON. It does not add or modify deployment manifests, operator code…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only a shell step-registry script. It does not add or modify an OTE binary, Go suite setup, or process-level logging. The changed helmfile command redirects stdout to …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request changes only the e2e setup shell script. The diff adds OIDC_ISSUER_MODE="mock" to an existing helmfile list command. It adds no Ginkgo tests and no IPv4 assumptions or new e…
No-Weak-Crypto	✅ Passed	The pull request changes only the helmfile list environment and command formatting. The added lines set OIDC_ISSUER_MODE="mock" and preserve the existing Helmfile arguments. No MD5, SHA1, DES, 3DE…
Container-Privileges	✅ Passed	PASS. The pull request changes one shell script only. The added code sets OIDC_ISSUER_MODE="mock" for a helmfile list command. It does not add or change privileged, host PID/network/IPC settings…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request adds only the literal environment assignment OIDC_ISSUER_MODE="mock" to the existing helmfile list command. The command's JSON stdout remains redirected to the cleanup manifest fi…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

@Mischulee: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[Mischulee]

/pj-rehearse

[openshift-merge-bot]

@Mischulee: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Mischulee]

/pj-rehearse abort

[openshift-merge-bot]

@Mischulee: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@Mischulee: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-deployment-validation	openshift-hyperfleet/hyperfleet-e2e	presubmit	Registry content changed
periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-rc-e2e-rc-e2e	N/A	periodic	Registry content changed
periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier0-nightly	N/A	periodic	Registry content changed
periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier1-nightly	N/A	periodic	Registry content changed
periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier2-nightly	N/A	periodic	Registry content changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[Mischulee]

/pj-rehearse periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier0-nightly

[openshift-merge-bot]

@Mischulee: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Mischulee]

/retest

[kuudori]

/retest

[kuudori]

/pj-rehearse periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier0-nightly

[openshift-merge-bot]

@kuudori: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[kuudori]

/pj-rehearse periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier0-nightly

[openshift-merge-bot]

@kuudori: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[kuudori]

/pj-rehearse periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier0-nightly

[openshift-merge-bot]

@kuudori: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[kuudori]

/pj-rehearse periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier0-nightly

[openshift-merge-bot]

@kuudori: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[kuudori]

/pj-rehearse abort

[openshift-merge-bot]

@kuudori: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[kuudori]

/pj-rehearse periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier0-nightly

[openshift-merge-bot]

@kuudori: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[kuudori]

/pj-rehearse periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier0-nightly

[openshift-merge-bot]

@kuudori: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[kuudori]

/pj-rehearse periodic-ci-openshift-hyperfleet-hyperfleet-e2e-main-e2e-tier0-nightly

[openshift-merge-bot]

@kuudori: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[kuudori]

/pj-rehearse ack

[openshift-merge-bot]

@kuudori: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[kuudori]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuudori, Mischulee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/openshift-hyperfleet/OWNERS [Mischulee,kuudori]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@Mischulee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.