Skip to content

[DO NOT MERGE] attempts to fix error due to missing prowgen: enable_secrets_store_cs… - #85395

Open
briandooley wants to merge 1 commit into
openshift:mainfrom
briandooley:serverless-jtbd-csi-fix
Open

briandooley wants to merge 1 commit into
openshift:mainfrom
briandooley:serverless-jtbd-csi-fix

Conversation

@briandooley

@briandooley briandooley commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

…i_driver: true

Summary by CodeRabbit

  • Enables secrets_store_csi_driver for generated Prow jobs in the OpenShift Serverless documentation CI configuration.
  • This change attempts to address the missing prowgen error.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: a3248ca5-4381-4a7f-a0f4-1a29637e484d

📥 Commits

Reviewing files that changed from the base of the PR and between a326286 and 52d27d7.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/openshift-docs/openshift-openshift-docs-serverless-docs-jtbd-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/openshift-docs/openshift-openshift-docs-serverless-docs-jtbd.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The configuration enables the secrets store CSI driver for generated Prow jobs.

Changes

Prowgen Configuration

Layer / File(s) Summary
Enable CSI driver generation
ci-operator/config/openshift/openshift-docs/openshift-openshift-docs-serverless-docs-jtbd.yaml
Adds prowgen.enable_secrets_store_csi_driver: true.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 52d27

The change enables the intended CSI driver configuration without an identified implementation or integration risk.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The check does not find any changed Ginkgo test titles. The pull request changes one CI configuration file and its generated Prow presubmit file. The additions enable the Secrets Store CSI driver and …
Test Structure And Quality ✅ Passed PASS: The pull request changes only two YAML configuration files. It adds prowgen.enable_secrets_store_csi_driver: true and regenerates Prow job configuration. The diff contains no Ginkgo test code,…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only two YAML configuration files. It adds prowgen.enable_secrets_store_csi_driver: true and generated CI job settings. It does not add or modify Ginkgo e2e tests, so …
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request adds only a prowgen configuration flag and generated Prow job settings for the Secrets Store CSI driver. The authoritative diff contains no new Ginkgo tests or test code, and it int…
Topology-Aware Scheduling Compatibility ✅ Passed PASS. The review-scoped diff changes one ci-operator config and its generated Prow presubmit file. It enables the Secrets Store CSI driver and adds a CSI volume, ConfigMap, mounts, and ci-operator arg…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only CI YAML. It adds prowgen.enable_secrets_store_csi_driver: true and generated ci-operator job arguments, mounts, and CSI volumes. It does not change an OTE binar…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS — The pull request changes only a Prow configuration file and its generated presubmit job file. It adds Secrets Store CSI driver arguments, mounts, and volumes. It does not add Ginkgo tests or in…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only Prow configuration and generated job manifests. It enables the Secrets Store CSI driver and mounts GSM credentials. The diff introduces no MD5, SHA1, DES, RC4, 3DES…
Container-Privileges ✅ Passed The pull request adds prowgen.enable_secrets_store_csi_driver: true and generates CSI secret volumes plus --enable-secrets-store-csi-driver=true in the two Prow jobs. The changed manifests add no …
No-Sensitive-Data-In-Logs ✅ Passed PASS. The review-scoped diff changes only the Prow configuration and its generated presubmit jobs. It adds prowgen.enable_secrets_store_csi_driver: true, the corresponding ci-operator flag, and re…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: enabling the missing prowgen Secrets Store CSI driver setting. The [DO NOT MERGE] prefix is appropriate for a temporary fix attempt.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briandooley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2026
@openshift-ci
openshift-ci Bot requested review from deepsm007 and jmguzik September 17, 2026 13:13
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@briandooley: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-openshift-docs-serverless-docs-jtbd-validate-asciidoc openshift/openshift-docs presubmit Presubmit changed
pull-ci-openshift-openshift-docs-serverless-docs-jtbd-validate-portal openshift/openshift-docs presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@briandooley briandooley changed the title attempts to fix error due to missing prowgen: enable_secrets_store_cs… [DO NOT MERGE] attempts to fix error due to missing prowgen: enable_secrets_store_cs… Sep 17, 2026
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@briandooley: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant