[release-controller] Aggregate jobs should not be Informing

[bradmwilliams]

This PR is a prerequisite for: openshift/release-controller#788 to merge since these files will automatically fail all PR's that run the release-controller specific tests once it goes live.

Summary by CodeRabbit

Updated release verification config for OpenShift release-controller so two aggregated jobs are no longer marked optional during 5.0 release checks. This affects the 5.0 release CI/release verification flow by making the aggregated-aws-ovn-upgrade-5.0-micro-fips and aggregated-hypershift-aks-conformance-5.0 jobs required rather than informational/optional, aligning the release configuration with the upcoming release-controller behavior change.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: cae4d471-d867-4d36-9f20-163af4f9dbee

📥 Commits

Reviewing files that changed from the base of the PR and between c1db7c0 and 49729d4.

📒 Files selected for processing (2)

• core-services/release-controller/_releases/priv/release-ocp-5.0.json
• core-services/release-controller/_releases/release-ocp-5.0.json

💤 Files with no reviewable changes (2)

• core-services/release-controller/_releases/priv/release-ocp-5.0.json
• core-services/release-controller/_releases/release-ocp-5.0.json

---

Walkthrough

Removes the "optional": true field from two verify entries (aggregated-aws-ovn-upgrade-5.0-micro-fips and aggregated-hypershift-aks-conformance-5.0) in both release-ocp-5.0.json and its priv counterpart, leaving other settings unchanged.

Changes

Verify optionality removal

Layer / File(s)	Summary
Remove optional flag from aggregated verify entries core-services/release-controller/_releases/release-ocp-5.0.json, core-services/release-controller/_releases/priv/release-ocp-5.0.json	Removes "optional": true from aggregated-aws-ovn-upgrade-5.0-micro-fips and aggregated-hypershift-aks-conformance-5.0 verify entries in both files, leaving retry counts and prowJob settings unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the change: aggregate release-controller jobs are no longer marked optional/informing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only edits release JSON verify config; no Ginkgo test titles were added or changed.
Test Structure And Quality	✅ Passed	PASS: The PR only changes two release JSON configs; no Ginkgo/test files or test logic were modified, so this test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; changed Go files contain only plain unit tests, and the release-controller JSON changes don't introduce MicroShift-unsupported APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR only edits release-controller JSON verify configs; no new or changed Ginkgo e2e tests were added, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only release-controller verify JSON changed; no manifests/controllers/scheduling constraints or topology-dependent fields were added.
Ote Binary Stdout Contract	✅ Passed	Only release-controller JSON configs changed; no process-level code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: PR only changes release-controller JSON; no new Ginkgo e2e tests or IP/network code were added.
No-Weak-Crypto	✅ Passed	Only JSON release verify metadata changed; no weak crypto, custom crypto code, or secret/token comparisons were added.
Container-Privileges	✅ Passed	Touched files are release-controller JSON configs only, and no privilege-related fields appear in the changed content.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The PR only edits release JSON verify entries, removing optional; no logging statements or log output were added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• core-services/release-controller/_releases/OWNERS [bradmwilliams]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bradmwilliams]

/hold
Want to get confirmation from TRT that all this is expected and OK to proceed

[openshift-merge-bot]

@bradmwilliams: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

[bradmwilliams]

/pj-rehearse ack

[openshift-merge-bot]

@bradmwilliams: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@bradmwilliams: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.