Move external ip policy test to disruptive-longrunning

[jacobsee]

The test does multiple KAS rollouts. Also bumps the longrunning test timout by 10 minutes.

Summary by CodeRabbit

• Tests
  • Increased the timeout for the disruptive long-running test suite from 40 to 50 minutes.
  • Updated the IPv4 external IP policy test to run as part of the disruptive long-running suite.

[openshift-ci]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3745f031-1cbc-4682-a819-1dedf019fead

📥 Commits

Reviewing files that changed from the base of the PR and between a475303 and e708c97.

📒 Files selected for processing (2)

• pkg/testsuites/standard_suites.go
• test/extended/networking/services.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The disruptive-longrunning suite timeout increases from 40 to 50 minutes. The IPv4 external IP policy test now uses the suite label and an inferred local declaration for retryInterval.

Changes

Disruptive long-running suite

Layer / File(s)	Summary
Suite timeout and test labeling pkg/testsuites/standard_suites.go, test/extended/networking/services.go	The suite timeout increases to 50 minutes. The IPv4 policy test receives the disruptive-longrunning label. The retryInterval declaration uses short variable syntax.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: dgoodwin

Merge Risk: ⚪ Minimal · up to e708c

The test is moved to the intended long-running suite and given additional time without introducing a current functional or operational risk.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: moving the external IP policy test to the disruptive-longrunning suite.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes one Ginkgo test title by adding the static tag [Suite:openshift/disruptive-longrunning]. The title contains no pod name, timestamp, UUID, node name, namespace, IP address, o…
Test Structure And Quality	✅ Passed	PASS. The reviewed diff changes only the disruptive-longrunning suite timeout from 40 to 50 minutes, changes retryInterval to an equivalent short declaration, and adds the suite tag. The test body, …
Microshift Test Compatibility	✅ Passed	No new Ginkgo test or MicroShift-incompatible behavior was introduced. The changed test already had the [apigroup:config.openshift.io] tag in the base revision, so MicroShift CI skips it because tha…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request does not introduce a new test or a multi-node assumption. The only test change adds the disruptive-longrunning suite label; the short variable declaration has no runtime effect.…
Topology-Aware Scheduling Compatibility	✅ Passed	The pull request changes only test-suite configuration and an extended networking test. It does not add or modify deployment manifests, operator code, controllers, replicas, affinity, topology spread,…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request changes only a suite timeout, a local variable declaration, and an It label. It adds no stdout write, logging setup, or Ginkgo suite-configuration output in process-level code…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request does not add a new Ginkgo test or change the test's network operations. It changes retryInterval to equivalent Go short-declaration syntax, adds the existing test to the disruptive-…
No-Weak-Crypto	✅ Passed	PASS: The pull request changes only a suite timeout, a Go variable declaration, and a Ginkgo suite label. The added lines contain no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography, sec…
Container-Privileges	✅ Passed	PASS. The pull request changes only the disruptive suite timeout, a local Go variable declaration, and a test suite label. The reviewed diff adds no privileged, hostPID, hostNetwork, hostIPC, …
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The pull request adds no logging. Its only changes are a suite timeout increase, a local variable declaration change, and a suite label. Existing logs remain unchanged and report generated servi…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jacobsee
Once this PR has been reviewed and has the lgtm label, please assign cpmeadors for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-ovn
/test e2e-metal-ipi-ovn-ipv6

[jacobsee]

/pipeline required

[openshift-ci]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-ovn
/test e2e-metal-ipi-ovn-ipv6

[jacobsee]

/pipeline required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-ovn
/test e2e-metal-ipi-ovn-ipv6

[redhat-chai-bot]

/override ci/prow/e2e-aws-ovn-microshift-serial

Automated triage: This failure appears unrelated to the PR changes.

Job classification: Eligible long-running MicroShift AWS e2e/integration presubmit. The job uses workflow openshift-microshift-e2e-origin-conformance, cluster profile openshift-org-aws, and multi-stage cluster setup plus conformance execution.
Revision check: Incoming/Prow run SHA e708c970dd58a3b97dca462d6d16a6fd7e562266; current PR HEAD e708c970dd58a3b97dca462d6d16a6fd7e562266; match.
Execution status: Tests executed. The suite ran for 33m3s and reported 6 blocking fail, 0 informing fail, 88 pass, 0 flaky, 463 skip; the test pod ran for about 38m before exiting with code 1.
Completed supporting jobs: No completed supporting e2e jobs. The PR currently has 9 passed checks, 1 failed check, and 7 pending checks; pending checks are not positive signal.
Fleet-wide failure rate: This job had 33 executions in the last 14 days: 100% pass Sep 3–9, 60% Sep 10–11, and 0% Sep 14–15. The same VolumeGroupSnapshotClass failure occurred across at least 7 unrelated PRs.
Overlap assessment: The PR changes pkg/testsuites/standard_suites.go (disruptive-longrunning suite timeout) and test/extended/networking/services.go (moves the external IP policy test into the disruptive-longrunning suite). The failing tests are upstream CSI storage VolumeGroupSnapshotClass tests and do not exercise those files or the changed external IP policy behavior; no direct or indirect overlap was found.
Missing-coverage risk: Low for this PR. The failed coverage is the MicroShift VolumeGroupSnapshotClass API path, which is unavailable in this environment; accepting this unrelated failure does not remove coverage of the PR's changed behavior from this run.
Rationale: The exact failures are pre-existing and environment-related: the server could not find the requested resource while listing VolumeGroupSnapshotClasses. The failing tests were:

• [sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: (delete policy)] volumegroupsnapshotclass [Feature:volumegroupsnapshot] VolumeGroupSnapshotClass should report error when VolumeGroupSnapshot is created without className and no default class exists [Serial]
• [sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: (delete policy)] volumegroupsnapshotclass [Feature:volumegroupsnapshot] VolumeGroupSnapshotClass should report error when VolumeGroupSnapshot is created without className and multiple default classes exist [Serial]
• [sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: (delete policy)] volumegroupsnapshotclass [Feature:volumegroupsnapshot] VolumeGroupSnapshotClass should use default VolumeGroupSnapshotClass when no className is specified [Serial]

If you disagree with this assessment, rerun the current job with /test e2e-aws-ovn-microshift-serial.

---

AI-generated. Review for accuracy.

[openshift-ci]

@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-aws-ovn-microshift-serial

Details

In response to this:

/override ci/prow/e2e-aws-ovn-microshift-serial

Automated triage: This failure appears unrelated to the PR changes.

Job classification: Eligible long-running MicroShift AWS e2e/integration presubmit. The job uses workflow openshift-microshift-e2e-origin-conformance, cluster profile openshift-org-aws, and multi-stage cluster setup plus conformance execution.
Revision check: Incoming/Prow run SHA e708c970dd58a3b97dca462d6d16a6fd7e562266; current PR HEAD e708c970dd58a3b97dca462d6d16a6fd7e562266; match.
Execution status: Tests executed. The suite ran for 33m3s and reported 6 blocking fail, 0 informing fail, 88 pass, 0 flaky, 463 skip; the test pod ran for about 38m before exiting with code 1.
Completed supporting jobs: No completed supporting e2e jobs. The PR currently has 9 passed checks, 1 failed check, and 7 pending checks; pending checks are not positive signal.
Fleet-wide failure rate: This job had 33 executions in the last 14 days: 100% pass Sep 3–9, 60% Sep 10–11, and 0% Sep 14–15. The same VolumeGroupSnapshotClass failure occurred across at least 7 unrelated PRs.
Overlap assessment: The PR changes pkg/testsuites/standard_suites.go (disruptive-longrunning suite timeout) and test/extended/networking/services.go (moves the external IP policy test into the disruptive-longrunning suite). The failing tests are upstream CSI storage VolumeGroupSnapshotClass tests and do not exercise those files or the changed external IP policy behavior; no direct or indirect overlap was found.
Missing-coverage risk: Low for this PR. The failed coverage is the MicroShift VolumeGroupSnapshotClass API path, which is unavailable in this environment; accepting this unrelated failure does not remove coverage of the PR's changed behavior from this run.
Rationale: The exact failures are pre-existing and environment-related: the server could not find the requested resource while listing VolumeGroupSnapshotClasses. The failing tests were:

• [sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: (delete policy)] volumegroupsnapshotclass [Feature:volumegroupsnapshot] VolumeGroupSnapshotClass should report error when VolumeGroupSnapshot is created without className and no default class exists [Serial]
• [sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: (delete policy)] volumegroupsnapshotclass [Feature:volumegroupsnapshot] VolumeGroupSnapshotClass should report error when VolumeGroupSnapshot is created without className and multiple default classes exist [Serial]
• [sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: (delete policy)] volumegroupsnapshotclass [Feature:volumegroupsnapshot] VolumeGroupSnapshotClass should use default VolumeGroupSnapshotClass when no className is specified [Serial]

If you disagree with this assessment, rerun the current job with /test e2e-aws-ovn-microshift-serial.

---

AI-generated. Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@jacobsee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-microshift	e708c97	link	true	/test e2e-aws-ovn-microshift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.