OPCT-460: Increase timeout for external IP policy test to accommodate in-cluster rollouts by redhat-chai-bot · Pull Request #31636 · openshift/origin

redhat-chai-bot · 2026-09-11T16:29:48Z

Summary

The test [sig-network] ensures external ip policy is configured correctly on the cluster triggers two sequential kube-apiserver rollouts when modifying and reverting the network.config.openshift.io ExternalIP policy. Each rollout takes ~9 minutes when the test runs in-cluster (OPCT/Sonobuoy), pushing the total runtime to ~18 minutes — exceeding the default 15-minute per-test timeout.

This adds [Timeout:30m] to give the test sufficient time for both rollouts with comfortable headroom for cluster variance. This follows the established pattern used by 31+ other tests in the codebase.

Details

The test passes 100% in standard CI (256/256 on Sippy for OCP 5.0) where openshift-tests runs externally
In OPCT, openshift-tests runs inside a pod on the cluster being tested — kube-apiserver restarts during rollout disrupt the in-cluster API connection
Each rollout takes ~9 min in-cluster vs ~3-4 min externally due to watch reconnection overhead
The 15-minute default timeout comes from openshift-tests binary's fallback when running openshift/conformance suite (which has no TestTimeout set)
The openshift/conformance/serial child suite has TestTimeout: 40m, but this is not inherited when running via the parent suite

Evidence

From failing OPCT CI job #2090101040597700608:

Rollout Add link to GOPATH doc and fixup typo #1: 9 min 6 sec (completed)
Rollout Add alpha API documentation #2: 5 min 48 sec (interrupted at 14m59s — test killed by Ginkgo timeout)
Goroutine dump: blocked on <-kubeAPIServerRollout.Done() at util.go:318

Fixes: https://redhat.atlassian.net/browse/OPCT-460

AI-generated. Review for accuracy.

@bshaw7 requested via Chai Bot

Summary by CodeRabbit

Tests
- Updated the IPv4 external IP policy test to allow up to 30 minutes for completion.
- This improves test reliability for environments where network-related operations may take longer than expected.

…r rollouts The test 'ensures external ip policy is configured correctly' triggers two sequential kube-apiserver rollouts when modifying and reverting the network.config.openshift.io ExternalIP policy. Each rollout takes ~9 minutes when the test runs in-cluster (OPCT/Sonobuoy), pushing the total runtime to ~18 minutes — exceeding the default 15-minute per-test timeout. Add [Timeout:30m] to give the test sufficient time for both rollouts with comfortable headroom for cluster variance. This follows the established pattern used by 31+ other tests in the codebase. Fixes: https://redhat.atlassian.net/browse/OPCT-460 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci · 2026-09-11T16:29:51Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

coderabbitai · 2026-09-11T16:30:13Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: e05f87cb-4a57-458b-aa1c-30ee53b012d6

📥 Commits

Reviewing files that changed from the base of the PR and between aec6a14 and f184c8c.

📒 Files selected for processing (1)

test/extended/networking/services.go

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

The IPv4 external IP policy test now has a 30-minute Ginkgo timeout label. Its behavior and assertions remain unchanged.

Changes

IPv4 external IP policy test

Layer / File(s)	Summary
Add test timeout label `test/extended/networking/services.go`	The test now declares a 30-minute timeout. Test behavior and assertions remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to f184c

The test receives sufficient time for its two sequential rollouts without changing its behavior or assertions.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: increasing the timeout for the external IP policy test to support in-cluster rollouts.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only the Ginkgo `It` title by adding the literal label `[Timeout:30m]`. The title contains no pod name, timestamp, UUID, node name, namespace, IP address, or runtime expressio…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only the Ginkgo test name by adding `[Timeout:30m]`. The authoritative diff contains no new test logic, resource creation, waits, assertions, or cleanup behavior. The ti…
Microshift Test Compatibility	✅ Passed	The pull request changes only the existing test name by adding `[Timeout:30m]`. It does not add a new Ginkgo test or change test API usage. The existing test already has `[apigroup:config.openshift.io…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only the existing test name by adding `[Timeout:30m]`; it does not add a new Ginkgo test. The existing test updates the network configuration and creates LoadBalancer se…
Topology-Aware Scheduling Compatibility	✅ Passed	The pull request changes only the Ginkgo test label in test/extended/networking/services.go, from the default timeout to [Timeout:30m]. It does not add or modify deployment manifests, operator code, c…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request changes only the Ginkgo test name by adding `[Timeout:30m]`. The changed line is inside an `It()` block, not process-level code. No `main()`, suite setup, logging redirection, o…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS. The review-scoped diff changes only the existing test name by adding `[Timeout:30m]`. It adds no Ginkgo test, IPv4 logic, or external connectivity. The existing IPv4 literals are unchanged, and …
No-Weak-Crypto	✅ Passed	PASS. The reviewed range changes only `test/extended/networking/services.go`, adding `[Timeout:30m]` to a Ginkgo test name. The patch introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cry…
Container-Privileges	✅ Passed	PASS. The review-scoped diff changes only the Ginkgo test name in `test/extended/networking/services.go` by adding `[Timeout:30m]`. The patch adds no Kubernetes or container manifest and no `privilege…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request changes only the Ginkgo test name by adding `[Timeout:30m]` in `test/extended/networking/services.go` (`1 insertion, 1 deletion`). The base and head revisions contain the same logging…

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

bshaw7 · 2026-09-11T16:37:12Z

/payload-job periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

openshift-ci · 2026-09-11T16:37:28Z

@bshaw7: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0b08d530-adff-11f1-897c-8817a19d0b7b-0

openshift-ci · 2026-09-11T17:43:35Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-ovn
/test e2e-metal-ipi-ovn-ipv6

redhat-chai-bot · 2026-09-11T17:46:34Z

/payload-job periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

AI-generated. Review for accuracy.

openshift-ci · 2026-09-11T17:46:38Z

@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bb95e3d0-ae08-11f1-8dbc-f69256b36c08-0

mtulio · 2026-09-11T18:27:54Z

/retitle OPCT-460: Increase timeout for external IP policy test to accommodate in-cluster rollouts

openshift-ci-robot · 2026-09-11T18:28:03Z

@redhat-chai-bot: This pull request references OPCT-460 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

The test [sig-network] ensures external ip policy is configured correctly on the cluster triggers two sequential kube-apiserver rollouts when modifying and reverting the network.config.openshift.io ExternalIP policy. Each rollout takes ~9 minutes when the test runs in-cluster (OPCT/Sonobuoy), pushing the total runtime to ~18 minutes — exceeding the default 15-minute per-test timeout.

This adds [Timeout:30m] to give the test sufficient time for both rollouts with comfortable headroom for cluster variance. This follows the established pattern used by 31+ other tests in the codebase.

Details

The test passes 100% in standard CI (256/256 on Sippy for OCP 5.0) where openshift-tests runs externally

In OPCT, openshift-tests runs inside a pod on the cluster being tested — kube-apiserver restarts during rollout disrupt the in-cluster API connection

Each rollout takes ~9 min in-cluster vs ~3-4 min externally due to watch reconnection overhead

The 15-minute default timeout comes from openshift-tests binary's fallback when running openshift/conformance suite (which has no TestTimeout set)

The openshift/conformance/serial child suite has TestTimeout: 40m, but this is not inherited when running via the parent suite

Evidence

From failing OPCT CI job #2090101040597700608:

Rollout Add link to GOPATH doc and fixup typo #1: 9 min 6 sec (completed)

Rollout Add alpha API documentation #2: 5 min 48 sec (interrupted at 14m59s — test killed by Ginkgo timeout)

Goroutine dump: blocked on <-kubeAPIServerRollout.Done() at util.go:318

Fixes: https://redhat.atlassian.net/browse/OPCT-460

AI-generated. Review for accuracy.

@bshaw7 requested via Chai Bot

Summary by CodeRabbit

Tests

Updated the IPv4 external IP policy test to allow up to 30 minutes for completion.

This improves test reliability for environments where network-related operations may take longer than expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mtulio · 2026-09-11T18:28:09Z

/assign @bshaw7

openshift-ci · 2026-09-11T19:11:50Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-ovn
/test e2e-metal-ipi-ovn-ipv6

bshaw7 · 2026-09-14T05:56:46Z

/payload-job periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws
/payload-job periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws-ccm

openshift-ci · 2026-09-14T05:56:50Z

@bshaw7: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws
periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws-ccm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1253be50-b001-11f1-94b8-17dfa03a1747-0

bshaw7 · 2026-09-16T05:56:10Z

/ok-to-test

bshaw7 · 2026-09-16T05:57:27Z

/payload-job periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws
/payload-job periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws-ccm

openshift-ci · 2026-09-16T05:57:31Z

@bshaw7: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws
periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws-ccm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8013b4c0-b193-11f1-8bfc-25878f1a5865-0

openshift-merge-bot · 2026-09-16T07:11:38Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-ovn
/test e2e-metal-ipi-ovn-ipv6

bshaw7 · 2026-09-16T14:20:40Z

In CI Test periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws and periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws-ccm Require test is getting passed and

Timeout:30m is visible as well

[sig-network] services when running openshift ipv4 cluster ensures external ip policy is configured correctly on the cluster [apigroup:config.openshift.io] [Serial] [Timeout:30m] [Suite:openshift/conformance/serial]

bshaw7 · 2026-09-16T14:21:19Z

/verified by CI test #31636 (comment)

openshift-ci-robot · 2026-09-16T14:21:32Z

@bshaw7: This PR has been marked as verified by CI test https://github.com/openshift/origin/pull/31636#issuecomment-5699037539.

Details

In response to this:

/verified by CI test #31636 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

redhat-chai-bot · 2026-09-16T14:27:24Z

/retest-required

The two failing MicroShift conformance tests (e2e-aws-ovn-microshift, e2e-aws-ovn-microshift-serial) are unrelated to this change — this PR only modifies a timeout in test/extended/networking/externalip.go. The failures are MicroShift-specific conformance issues (6 blocking failures each). Retesting.

AI-generated. Review for accuracy.

openshift-ci · 2026-09-16T16:31:13Z

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mtulio · 2026-09-17T13:15:07Z

Test results are pointing that we need that timeout increase to cover more wider variants.

/lgtm

openshift-ci · 2026-09-17T13:20:08Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtulio, redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

test/extended/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mtulio · 2026-09-17T17:07:34Z

PTAL @danwinship ?

/assign danwinship

openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Sep 11, 2026

openshift-ci Bot requested review from miheer and tssurya September 11, 2026 16:30

coderabbitai Bot approved these changes Sep 11, 2026

View reviewed changes

openshift-ci Bot changed the title ~~Increase timeout for external IP policy test to accommodate in-cluster rollouts~~ OPCT-460: Increase timeout for external IP policy test to accommodate in-cluster rollouts Sep 11, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2026

openshift-ci Bot assigned bshaw7 Sep 11, 2026

openshift-ci Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 16, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 16, 2026

openshift-ci Bot assigned mtulio Sep 17, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2026

openshift-ci Bot assigned danwinship Sep 17, 2026

Conversation

redhat-chai-bot commented Sep 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Evidence

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented Sep 11, 2026

Uh oh!

coderabbitai Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

bshaw7 commented Sep 11, 2026

Uh oh!

openshift-ci Bot commented Sep 11, 2026

Uh oh!

openshift-ci Bot commented Sep 11, 2026

Uh oh!

redhat-chai-bot commented Sep 11, 2026

Uh oh!

openshift-ci Bot commented Sep 11, 2026

Uh oh!

mtulio commented Sep 11, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 11, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Evidence

Summary by CodeRabbit

Uh oh!

mtulio commented Sep 11, 2026

Uh oh!

openshift-ci Bot commented Sep 11, 2026

Uh oh!

bshaw7 commented Sep 14, 2026

Uh oh!

openshift-ci Bot commented Sep 14, 2026

Uh oh!

bshaw7 commented Sep 16, 2026

Uh oh!

bshaw7 commented Sep 16, 2026

Uh oh!

openshift-ci Bot commented Sep 16, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 16, 2026

Uh oh!

bshaw7 commented Sep 16, 2026

Uh oh!

bshaw7 commented Sep 16, 2026

Uh oh!

openshift-ci-robot commented Sep 16, 2026

Uh oh!

redhat-chai-bot commented Sep 16, 2026

Uh oh!

openshift-ci Bot commented Sep 16, 2026

Uh oh!

mtulio commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Sep 17, 2026

Uh oh!

mtulio commented Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

redhat-chai-bot commented Sep 11, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 11, 2026 •

edited

Loading

mtulio commented Sep 11, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Sep 11, 2026 •

edited by openshift-ci Bot

Loading

mtulio commented Sep 17, 2026 •

edited

Loading