Stabilize Amphora serial LB tests: per-spec teardown and sourceRanges wait fix

[tusharjadhav3302]

Summary

• Serial Amphora [lb] specs can leave Octavia LBs behind between Its, which under max-shared-lb / amphora capacity pressure contributes to ensure-LB timeouts in osp_verification.
• Register Amphora-only DeferCleanup for the create, ETP:Local+monitors, and UDP sourceRanges Its (delete Service + cascade-delete Octavia LB if it remains). Registered before CreateLoadBalancerService so a timed-out ensure still cleans up. OVN / other [lb] specs unchanged.
• Fix lbProviderUnderTest == "amphora" case mismatch (EqualFold) so Amphora actually waits for listener allowed_cidrs → 0.0.0.0/0 after clearing loadBalancerSourceRanges (previously took the OVN 30s sleep path). On post-open UDP failure, dump listener ACL / LB / pool / member state and a sourceRanges_diag_verdict.

Test plan

• Review Amphora-gated teardown limited to the three Its above
• CI: build / images / test / verify (pre-squash; re-check after squash)
• serval71: combined with shiftstack-qa PR #41 — late sourceRanges phase PASS (ACL allow-all ~2s); teardown helpers present in binary

Related

• Complements shiftstack/shiftstack-qa#41 (late Amphora sourceRanges phase under less OCCM contention). Does not fix OCCM allow-all stall under heavy load; improves wait correctness and leftover LB hygiene.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gryf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tusharjadhav3302: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.