export BIN_DIR to PATH so golint is found on Go 1.22 builder - #156
export BIN_DIR to PATH so golint is found on Go 1.22 builder#156sunku5494 wants to merge 2 commits into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sunku5494 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pipeline required |
|
Scheduling required tests: |
The get_tools.sh installs golint into BIN_DIR via GOBIN, but
check_golint.sh invokes it as a bare command. On the Go 1.22
builder (release-4.18) BIN_DIR is not in PATH, causing
'golint: command not found'. Exporting PATH fixes this
consistently across all Go versions.
Signed-off-by: Venkata Charan Sunku <vsunku@redhat.com>
f11b187 to
4bd6dbb
Compare
go install -mod=mod pkg@version silently skips installation on Go 1.22. Build golint directly from the vendored source instead, and prepend $(pwd)/bin to PATH in check_golint.sh since each make recipe runs in its own shell and does not inherit exports from get_tools.sh.
|
/test pull-ci-openshift-network-metrics-daemon-release-4.18-unit |
|
@sunku5494: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sunku5494: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The get_tools.sh installs golint into BIN_DIR via GOBIN, but check_golint.sh invokes it as a bare command. On the Go 1.22
builder (release-4.18) BIN_DIR is not in PATH, causing 'golint: command not found'. Exporting PATH fixes this consistently across all Go versions.