Skip to content

USHIFT-7118: Move C2CC scenarios for new prow job#6892

Open
pmtk wants to merge 2 commits into
openshift:mainfrom
pmtk:c2cc/prow-job
Open

USHIFT-7118: Move C2CC scenarios for new prow job#6892
pmtk wants to merge 2 commits into
openshift:mainfrom
pmtk:c2cc/prow-job

Conversation

@pmtk

@pmtk pmtk commented Jun 17, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests
    • Restructured container conversion test scenarios, consolidating RHEL 10.2 and RHEL 9.8 test cases to a new centralized directory structure for improved test organization.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 17, 2026

Copy link
Copy Markdown

@pmtk: This pull request references USHIFT-7118 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6a987a05-473f-4db4-a66e-f12f895a4472

📥 Commits

Reviewing files that changed from the base of the PR and between 08c4d7b and e452d47.

📒 Files selected for processing (10)
  • test/scenarios-bootc/c2cc/el102-src@c2cc-ipsec.sh
  • test/scenarios-bootc/c2cc/el102-src@c2cc-ipv6.sh
  • test/scenarios-bootc/c2cc/el102-src@c2cc.sh
  • test/scenarios-bootc/c2cc/el98-src@c2cc-ipsec.sh
  • test/scenarios-bootc/c2cc/el98-src@c2cc-ipv6.sh
  • test/scenarios-bootc/c2cc/el98-src@c2cc.sh
  • test/scenarios-bootc/el10/presubmits/el102-src@c2cc.sh
  • test/scenarios-bootc/el10/presubmits/el102-src@c2cc.sh
  • test/scenarios-bootc/el9/presubmits/el98-src@c2cc.sh
  • test/scenarios-bootc/el9/presubmits/el98-src@c2cc.sh

Walkthrough

Two c2cc scenario scripts (el102-src@c2cc.sh, el98-src@c2cc.sh) are relocated from version-specific presubmit directories (el10/presubmits/, el9/presubmits/) to a shared test/scenarios-bootc/c2cc/ directory. The script contents and logic remain identical.

C2CC Scenario Script Relocation

Layer / File(s) Summary
New shared c2cc scenario scripts
test/scenarios-bootc/c2cc/el102-src@c2cc.sh, test/scenarios-bootc/c2cc/el98-src@c2cc.sh, test/scenarios-bootc/el10/presubmits/el102-src@c2cc.sh, test/scenarios-bootc/el9/presubmits/el98-src@c2cc.sh
Scripts with scenario_create_vms, scenario_remove_vms, and scenario_run_tests are added under the shared c2cc/ directory; the originals in version-specific presubmit directories are deleted.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/microshift#6827: Introduces the c2cc_common.sh helpers (c2cc_create_vms, c2cc_remove_vms, c2cc_run_tests) that the new scripts delegate to.

Suggested reviewers

  • jerpeter1
🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: moving C2CC scenarios to support a new prow job, which aligns with the changeset of relocating scenario files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains Bash scenario scripts and Robot Framework tests with stable, deterministic test names. No Ginkgo tests found; check not applicable.
Test Structure And Quality ✅ Passed PR contains only Bash scenario scripts that orchestrate Robot Framework tests, not Ginkgo test code. The check applies only to Ginkgo tests and is not applicable here.
Microshift Test Compatibility ✅ Passed PR adds only Bash scenario scripts and removes test locations; no new Ginkgo e2e tests are present. Custom check for Ginkgo test MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains only bash scenario scripts that orchestrate test infrastructure (VM creation, removal), not Ginkgo e2e tests. Check applies only to new Ginkgo tests (It(), Describe(), etc.), so this PR...
Topology-Aware Scheduling Compatibility ✅ Passed PR only adds/modifies test scenario shell scripts, not deployment manifests, operator code, or controllers. Custom check applies only when those artifacts are changed.
Ote Binary Stdout Contract ✅ Passed PR contains only Bash shell scripts, not Go binaries. OTE stdout contract only applies to Go binaries communicating via JSON; Bash scenario scripts are not subject to this check.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds Bash scenario scripts, not Ginkgo e2e tests. Custom check targets Go Ginkgo tests (It(), Describe(), etc.), which are not present in this PR.
No-Weak-Crypto ✅ Passed PR adds test scenario scripts with no weak cryptography. Only crypto usage is secure openssl random generation for IPsec PSK.
Container-Privileges ✅ Passed PR adds bash test scenario scripts, not K8s manifests or container configs. No privileged container settings detected in the changed files.
No-Sensitive-Data-In-Logs ✅ Passed New scenario scripts contain only function definitions calling shared helpers; no logging or sensitive data exposure. Existing code properly protects secrets (PSK redirected to /dev/null).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from copejon and vanhalenar June 17, 2026 13:54
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2026
@pmtk

pmtk commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

/retest

@agullon

agullon commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2026
@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk

pmtk commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@pmtk

pmtk commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

/retest

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@pmtk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests e452d47 link true /test e2e-aws-tests
ci/prow/e2e-aws-tests-arm e452d47 link true /test e2e-aws-tests-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants