Fix OCP-89594: Remove deviceSelector from devicediscovery template

[mmakwana30]

Logs: https://privatebin.corp.redhat.com/?fa7f8e3fe7a5933f#5bQ2jABFURLfNXVtynRD51htpbRKN439HpfsZ13SmtZ7

Summary by CodeRabbit

• Configuration
  • Removed the forced device wipe setting from the LVMCluster device discovery template.

[openshift-ci-robot]

@mmakwana30: No Jira issue with key OCP-89594 exists in the tracker at https://redhat.atlassian.net.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The test LVMCluster device discovery template no longer configures forced device wiping and destruction of all data.

Changes

Device discovery template

Layer / File(s)	Summary
Remove forced device wiping setting test/integration/qe_tests/testdata/lvmcluster-devicediscovery-template.yaml	The template removes deviceSelector.forceWipeDevicesAndDestroyAllData.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit only removes two YAML lines; it changes no Ginkgo declarations. The related test title is a static string with no runtime values.
Test Structure And Quality	✅ Passed	The commit changes only the YAML fixture; it adds or modifies no Ginkgo It, BeforeEach, AfterEach, Eventually, or Consistently code, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	The PR changes only an existing YAML template and removes two lines; it adds no Ginkgo tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only a YAML fixture and removes two settings; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The HEAD patch only deletes two deviceSelector lines from a QE LVMCluster template; it adds no deployment, controller, replica, affinity, topology, node, taint, or PDB scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a YAML template. It adds no OTE process-level code or stdout writes; the OTE entry point and klog setup remain unchanged.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes only a YAML template and removes two settings; it adds no Ginkgo e2e test code or network access.
No-Weak-Crypto	✅ Passed	The patch changes only one YAML template and deletes forceWipeDevicesAndDestroyAllData; it adds no cryptography, weak algorithm, custom crypto, or secret comparison.
Container-Privileges	✅ Passed	The only change removes deviceSelector.forceWipeDevicesAndDestroyAllData; the resulting template contains no privileged, host namespace, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The change only removes two YAML lines; it adds no logging and the current template contains no credential, PII, session-ID, or hostname values.
Title check	✅ Passed	The title clearly and concisely describes the removal of deviceSelector from the devicediscovery template.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@mmakwana30: No Jira issue with key OCP-89594 exists in the tracker at https://redhat.atlassian.net.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Summary by CodeRabbit

• Configuration
• Removed the forced device wipe setting from the LVMCluster device discovery template.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmakwana30
Once this PR has been reviewed and has the lgtm label, please assign eggfoobar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@mmakwana30: No Jira issue with key OCP-89594 exists in the tracker at https://redhat.atlassian.net.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Logs: https://privatebin.corp.redhat.com/?fa7f8e3fe7a5933f#5bQ2jABFURLfNXVtynRD51htpbRKN439HpfsZ13SmtZ7

Summary by CodeRabbit

• Configuration
• Removed the forced device wipe setting from the LVMCluster device discovery template.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.18%. Comparing base (c298969) to head (6182577).
⚠️ Report is 194 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3030      +/-   ##
==========================================
- Coverage   54.62%   54.18%   -0.44%     
==========================================
  Files          54       53       -1     
  Lines        4225     4239      +14     
==========================================
- Hits         2308     2297      -11     
- Misses       1734     1759      +25     
  Partials      183      183              

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mmakwana30]

/test e2e-aws-hypershift

[openshift-ci]

@mmakwana30: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-hypershift	6182577	link	true	/test e2e-aws-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.