PF5: OLS-3501: Remove generic tool call error alert message

[kyoto]

Summary by CodeRabbit

• Bug Fixes

  • Improved tool error modal behavior by removing the redundant unexpected-error alert.
  • Tool error details now display the relevant status and error information without incorrectly showing rejection messaging.

• Tests

  • Added coverage for streamed responses containing tool errors to help ensure the modal presents accurate information.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

📝 Walkthrough

Walkthrough

The tool error modal no longer displays a generic error alert. English translations for that alert were removed, and a streamed tool-error fixture with browser coverage was added.

Changes

Tool error modal

Layer / File(s)	Summary
Remove generic error alert src/components/ResponseToolModal.tsx, locales/en/plugin__lightspeed-console-plugin.json	The modal skips the generic error alert for tool-call errors, and its two English translation entries were removed.
Cover streamed tool errors tests/support/fixtures.ts, tests/tests/lightspeed.spec.ts	A failing SSE fixture and serial test verify tool status, output, error text, and the absence of “Tool call rejected”.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openshift/lightspeed-console#2219: Contains the same modal, translation, fixture, and test changes.

Suggested reviewers: joshuawilson, syedriko

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the main change: removing the generic tool call error alert message.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@kyoto: This pull request references OLS-3501 which is a valid jira issue.

Details

In response to this:

Summary by CodeRabbit

• Bug Fixes

• Improved tool error modal behavior by removing the redundant unexpected-error alert.

• Tool error details now display the relevant status and error information without incorrectly showing rejection messaging.

• Tests

• Added coverage for streamed responses containing tool errors to help ensure the modal presents accurate information.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.