Skip to content

Fix eslint warning#2220

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
kyoto:fix-eslint-warning
Jul 17, 2026
Merged

Fix eslint warning#2220
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
kyoto:fix-eslint-warning

Conversation

@kyoto

@kyoto kyoto commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved log preview error messages by ensuring they use the latest available translations.

@kyoto kyoto added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 14, 2026
@openshift-ci
openshift-ci Bot requested review from joshuawilson and xrajesh July 14, 2026 10:51
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a0f84e94-576a-4091-8be3-e0196d85c302

📥 Commits

Reviewing files that changed from the base of the PR and between de8b98d and fdbb002.

📒 Files selected for processing (1)
  • src/components/AttachLogModal.tsx

📝 Walkthrough

Walkthrough

AttachLogModal moves the react-hooks/exhaustive-deps suppression comment from the loadPreview definition to its dependency array. No exported APIs or runtime behavior changed.

Changes

AttachLogModal lint suppression

Layer / File(s) Summary
Move dependency lint suppression
src/components/AttachLogModal.tsx
The react-hooks/exhaustive-deps suppression comment was relocated to immediately precede the loadPreview dependency array.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: joshuawilson, xrajesh

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the change: a small ESLint warning fix in AttachLogModal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@kyoto

kyoto commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

/cherry-pick release-4.19
/cherry-pick pattern-fly-5

@openshift-cherrypick-robot

Copy link
Copy Markdown

@kyoto: once the present PR merges, I will cherry-pick it on top of pattern-fly-5, release-4.19 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-4.19
/cherry-pick pattern-fly-5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/AttachLogModal.tsx`:
- Line 352: Update the effect dependencies around the debounced loadPreview so
cleanup calls loadPreview.cancel() before the locale-dependent function is
replaced, preventing pending timers from using stale t and updating
previewError. Keep the existing preview-loading behavior unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 888d7910-faa2-43ba-8db9-9e01345438dd

📥 Commits

Reviewing files that changed from the base of the PR and between 4a897c3 and de8b98d.

📒 Files selected for processing (1)
  • src/components/AttachLogModal.tsx

Comment thread src/components/AttachLogModal.tsx Outdated
@kyoto
kyoto force-pushed the fix-eslint-warning branch from de8b98d to fdbb002 Compare July 15, 2026 03:44
@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2026
@kyoto kyoto added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2026
@kyoto

kyoto commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

/lgtm

Override test failure unrelated to this change:
/override "Red Hat Konflux / e2e-console-pf6 / lightspeed-console"

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

@kyoto: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Override test failure unrelated to this change:
/override "Red Hat Konflux / e2e-console-pf6 / lightspeed-console"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

@kyoto: Overrode contexts on behalf of kyoto: Red Hat Konflux / e2e-console-pf6 / lightspeed-console

Details

In response to this:

/lgtm

Override test failure unrelated to this change:
/override "Red Hat Konflux / e2e-console-pf6 / lightspeed-console"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 4ad9b09 into openshift:main Jul 17, 2026
5 of 6 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown

@kyoto: #2220 failed to apply on top of branch "release-4.19":

Applying: Fix eslint warning
Using index info to reconstruct a base tree...
M	src/components/AttachLogModal.tsx
Falling back to patching base and 3-way merge...
Auto-merging src/components/AttachLogModal.tsx
CONFLICT (content): Merge conflict in src/components/AttachLogModal.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Fix eslint warning

Details

In response to this:

/cherry-pick release-4.19
/cherry-pick pattern-fly-5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

Copy link
Copy Markdown

@kyoto: #2220 failed to apply on top of branch "pattern-fly-5":

Applying: Fix eslint warning
Using index info to reconstruct a base tree...
M	src/components/AttachLogModal.tsx
Falling back to patching base and 3-way merge...
Auto-merging src/components/AttachLogModal.tsx
CONFLICT (content): Merge conflict in src/components/AttachLogModal.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Fix eslint warning

Details

In response to this:

/cherry-pick release-4.19
/cherry-pick pattern-fly-5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyoto
kyoto deleted the fix-eslint-warning branch July 17, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants