Periodic sync of supported OCP samples#695
Open
aroyoredhat wants to merge 1 commit into
Open
Conversation
WalkthroughRails templates now set explicit container images, and the OpenShift ImageStream manifests update Node.js tags to 22, add PHP 8.4 and Perl 5.32 tags, remove specific Python tags, and add Ruby 4.0 tags across architectures. ChangesOpenShift sample image manifests
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 10❌ Failed checks (10 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aroyoredhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
aroyoredhat
force-pushed
the
periodic-ocp-sync
branch
from
e4a284d to
7a9f263
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/operator/ocp-aarch64/php/imagestreams/php-rhel-aarch64.json`:
- Around line 166-176: Verify that the backing image referenced by the PHP 8.4
(Latest) imagestream is actually available and pullable: check
registry.redhat.io for registry.redhat.io/ubi10/php-84:latest and attempt a
docker/podman pull (using Red Hat credentials if required); if the image is
missing or not accessible, update the imagestream "from.name" value (currently
"8.4-ubi10") to a valid ImageStreamTag or explicit image reference that exists,
or add a note in the imagestream metadata documenting that Red Hat registry
credentials are required and provide the correct pullspec to avoid deployment
failures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 61022e20-2acf-4d92-b17b-3e93898b2550
📒 Files selected for processing (12)
assets/operator/ocp-aarch64/nodejs/imagestreams/nodejs-rhel-aarch64.jsonassets/operator/ocp-aarch64/php/imagestreams/php-rhel-aarch64.jsonassets/operator/ocp-aarch64/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-ppc64le/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-ppc64le/php/imagestreams/php-rhel.jsonassets/operator/ocp-ppc64le/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-s390x/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-s390x/php/imagestreams/php-rhel.jsonassets/operator/ocp-s390x/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-x86_64/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-x86_64/php/imagestreams/php-rhel.jsonassets/operator/ocp-x86_64/rails/templates/rails-pgsql-persistent.json
💤 Files with no reviewable changes (4)
- assets/operator/ocp-ppc64le/nodejs/imagestreams/nodejs-rhel.json
- assets/operator/ocp-s390x/nodejs/imagestreams/nodejs-rhel.json
- assets/operator/ocp-x86_64/nodejs/imagestreams/nodejs-rhel.json
- assets/operator/ocp-aarch64/nodejs/imagestreams/nodejs-rhel-aarch64.json
Contributor
Author
|
/retest-required |
aroyoredhat
force-pushed
the
periodic-ocp-sync
branch
from
7a9f263 to
f0e2efb
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/operator/ocp-ppc64le/perl/imagestreams/perl-rhel.json`:
- Line 50: The image entry "registry.redhat.io/ubi8/perl-532:latest" currently
shows as reachable at the manifest endpoint but requires authenticated pulls
(anonymous returns 401); update the image accessibility check and documentation
to require verifying an authenticated pull: log into registry.redhat.io (e.g.,
podman login or skopeo login), then run podman pull or skopeo inspect against
registry.redhat.io/ubi8/perl-532:latest to confirm success, and annotate the
asset (or README) to state that a valid Red Hat pull secret/credentials are
required for deployment (include the existing README link
https://github.com/sclorg/s2i-perl-container/blob/master/5.32/README.md as
reference).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f171a372-d6b0-4e4e-b2d3-d35a949a2e78
📒 Files selected for processing (20)
assets/operator/ocp-aarch64/nodejs/imagestreams/nodejs-rhel-aarch64.jsonassets/operator/ocp-aarch64/perl/imagestreams/perl-rhel-aarch64.jsonassets/operator/ocp-aarch64/php/imagestreams/php-rhel-aarch64.jsonassets/operator/ocp-aarch64/python/imagestreams/python-rhel-aarch64.jsonassets/operator/ocp-aarch64/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-ppc64le/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-ppc64le/perl/imagestreams/perl-rhel.jsonassets/operator/ocp-ppc64le/php/imagestreams/php-rhel.jsonassets/operator/ocp-ppc64le/python/imagestreams/python-rhel.jsonassets/operator/ocp-ppc64le/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-s390x/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-s390x/perl/imagestreams/perl-rhel.jsonassets/operator/ocp-s390x/php/imagestreams/php-rhel.jsonassets/operator/ocp-s390x/python/imagestreams/python-rhel.jsonassets/operator/ocp-s390x/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-x86_64/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-x86_64/perl/imagestreams/perl-rhel.jsonassets/operator/ocp-x86_64/php/imagestreams/php-rhel.jsonassets/operator/ocp-x86_64/python/imagestreams/python-rhel.jsonassets/operator/ocp-x86_64/rails/templates/rails-pgsql-persistent.json
💤 Files with no reviewable changes (8)
- assets/operator/ocp-ppc64le/nodejs/imagestreams/nodejs-rhel.json
- assets/operator/ocp-s390x/python/imagestreams/python-rhel.json
- assets/operator/ocp-s390x/nodejs/imagestreams/nodejs-rhel.json
- assets/operator/ocp-aarch64/python/imagestreams/python-rhel-aarch64.json
- assets/operator/ocp-aarch64/nodejs/imagestreams/nodejs-rhel-aarch64.json
- assets/operator/ocp-ppc64le/python/imagestreams/python-rhel.json
- assets/operator/ocp-x86_64/nodejs/imagestreams/nodejs-rhel.json
- assets/operator/ocp-x86_64/python/imagestreams/python-rhel.json
✅ Files skipped from review due to trivial changes (1)
- assets/operator/ocp-aarch64/perl/imagestreams/perl-rhel-aarch64.json
🚧 Files skipped from review as they are similar to previous changes (8)
- assets/operator/ocp-ppc64le/rails/templates/rails-pgsql-persistent.json
- assets/operator/ocp-x86_64/php/imagestreams/php-rhel.json
- assets/operator/ocp-s390x/rails/templates/rails-pgsql-persistent.json
- assets/operator/ocp-aarch64/rails/templates/rails-pgsql-persistent.json
- assets/operator/ocp-x86_64/rails/templates/rails-pgsql-persistent.json
- assets/operator/ocp-ppc64le/php/imagestreams/php-rhel.json
- assets/operator/ocp-s390x/php/imagestreams/php-rhel.json
- assets/operator/ocp-aarch64/php/imagestreams/php-rhel-aarch64.json
| }, | ||
| "from": { | ||
| "kind": "DockerImage", | ||
| "name": "registry.redhat.io/ubi8/perl-532:latest" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the Perl 5.32 UBI8 container image is available
echo "Checking if the Perl 5.32 UBI8 image is accessible..."
# Use skopeo to inspect the image manifest without pulling
skopeo inspect docker://registry.redhat.io/ubi8/perl-532:latest --format "Image exists: {{.Name}}:{{.Tag}}, Digest: {{.Digest}}" || echo "ERROR: Image not accessible"Repository: openshift/cluster-samples-operator
Length of output: 223
🏁 Script executed:
#!/bin/bash
# Verify the documentation URL is accessible
echo "Checking README URL..."
curl -sL -w "\nHTTP Status: %{http_code}\n" -o /dev/null "https://github.com/sclorg/s2i-perl-container/blob/master/5.32/README.md"Repository: openshift/cluster-samples-operator
Length of output: 119
🏁 Script executed:
#!/bin/bash
set -euo pipefail
repo_root="."
img="registry.redhat.io/ubi8/perl-532:latest"
file="assets/operator/ocp-ppc64le/perl/imagestreams/perl-rhel.json"
echo "== File snippet (around $file:50) =="
nl -ba "$file" | sed -n '40,60p'
echo "== Repo-wide references to the image tag =="
rg -n --fixed-string "$img" . || true
echo "== Direct registry manifest probe (no auth) =="
# This will typically return 401 (auth required) or 404 (not found). Both are useful signals.
# For consistency, try both `latest` and `v2/.../manifests/latest`.
url="https://registry.redhat.io/v2/ubi8/perl-532/manifests/latest"
curl -sS -o /dev/null -D - -w "HTTP_CODE=%{http_code}\n" "$url" || trueRepository: openshift/cluster-samples-operator
Length of output: 231
🏁 Script executed:
#!/bin/bash
set -euo pipefail
file="assets/operator/ocp-ppc64le/perl/imagestreams/perl-rhel.json"
img="registry.redhat.io/ubi8/perl-532:latest"
echo "== JSON snippet around referenced line (approx 45-55) =="
sed -n '45,55p' "$file" || true
echo
echo "== Repo-wide references to the exact image string =="
if command -v rg >/dev/null 2>&1; then
rg -n --fixed-string "$img" . || true
else
grep -RIn --fixed-string "$img" . || true
fi
echo
echo "== Direct registry manifest probe (no auth) =="
url="https://registry.redhat.io/v2/ubi8/perl-532/manifests/latest"
# Capture status line + any error body (short) to distinguish 404 vs 401 vs others.
curl -sS -D - \
-H "Accept: application/vnd.docker.distribution.manifest.v2+json" \
--max-time 30 \
"$url" | head -n 40 || trueRepository: openshift/cluster-samples-operator
Length of output: 1448
🌐 Web query:
Does registry.redhat.io/ubi8/perl-532:latest exist (UBI8 Perl 5.32 image tag), and what is the correct tag name?
💡 Result:
Yes, the ubi8/perl-532 image exists in the Red Hat container registry [1][2][3]. The correct image path to use is registry.redhat.io/ubi8/perl-532 [1][2]. For container images, the "latest" tag is frequently used to point to the most recent version of an image stream [2]. While you can use registry.redhat.io/ubi8/perl-532:latest, Red Hat container images are also frequently versioned with specific release tags to ensure build reproducibility [1][4][5][6]. You can verify the specific tags available for this image by consulting the Red Hat Ecosystem Catalog or by using container CLI tools to inspect the repository [2][7].
Citations:
- 1: https://access.redhat.com/errata/RHBA-2025:8445
- 2: https://catalog.redhat.com/en/software/containers/ubi8/perl-532/61f7a138ba9e057a1e43ca6a
- 3: https://ftp.redhat.com/pub/redhat/containers/ubi8/
- 4: https://access.redhat.com/errata/RHBA-2025:2759
- 5: https://access.redhat.com/errata/RHBA-2025:0800
- 6: https://access.redhat.com/errata/RHBA-2023:4550
- 7: https://access.redhat.com/articles/4238681
Update image accessibility check: confirm pull with registry auth (401 ≠ missing)
registry.redhat.io/ubi8/perl-532:latestresolves at the manifest endpoint, but anonymous access returns 401 UNAUTHORIZED (Bearer auth required), so deployment success depends on having valid pull credentials/pull secret.- README link
https://github.com/sclorg/s2i-perl-container/blob/master/5.32/README.mdreturns HTTP 200.
Suggested follow-up check: run the pull/inspect after logging in (e.g., podman login registry.redhat.io or skopeo login ... with appropriate credentials), then confirm podman pull registry.redhat.io/ubi8/perl-532:latest (or skopeo inspect ...) succeeds.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/operator/ocp-ppc64le/perl/imagestreams/perl-rhel.json` at line 50, The
image entry "registry.redhat.io/ubi8/perl-532:latest" currently shows as
reachable at the manifest endpoint but requires authenticated pulls (anonymous
returns 401); update the image accessibility check and documentation to require
verifying an authenticated pull: log into registry.redhat.io (e.g., podman login
or skopeo login), then run podman pull or skopeo inspect against
registry.redhat.io/ubi8/perl-532:latest to confirm success, and annotate the
asset (or README) to state that a valid Red Hat pull secret/credentials are
required for deployment (include the existing README link
https://github.com/sclorg/s2i-perl-container/blob/master/5.32/README.md as
reference).
aroyoredhat
force-pushed
the
periodic-ocp-sync
branch
from
f0e2efb to
20a4297
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/operator/ocp-aarch64/ruby/imagestreams/ruby-rhel-aarch64.json`:
- Around line 100-120: The new Ruby 4.0 imagestream entry should also update the
default `latest` alias so it points to Ruby 4.0 instead of still resolving to
`3.3-ubi9`. Adjust the `latest` image definition in `ruby-rhel-aarch64.json`
alongside the existing 4.0-ubi9 entry so the default tag and its annotations
consistently track the new major version, matching the `latest` behavior used by
consumers.
In `@assets/operator/ocp-ppc64le/ruby/imagestreams/ruby-rhel.json`:
- Around line 100-120: The Ruby imagestream still leaves the latest tag pointing
at the older 3.3 UBI 9 image instead of the new Ruby 4.0 release. Update the
latest entry in ruby-rhel.json so its from.name resolves to the Ruby 4.0 UBI 9
Docker image, and make sure the related latest annotations stay consistent with
the existing 4.0-ubi9 and 3.3-ubi9 definitions.
In `@assets/operator/ocp-s390x/ruby/imagestreams/ruby-rhel.json`:
- Around line 100-120: Update the Ruby imagestream entry for the latest tag so
it points to the new Ruby 4.0 UBI 9 image instead of the current 3.3 target;
adjust the `latest` mapping in `ruby-rhel.json` consistently with the new
`4.0-ubi9` entry so default consumers resolve to Ruby 4.0. Use the `name:
latest` and `from` blocks in the imagestream definition to locate and update the
correct tag target.
In `@assets/operator/ocp-x86_64/ruby/imagestreams/ruby-rhel.json`:
- Around line 100-120: The imagestream still points the latest tag to the Ruby
3.3 UBI 9 image, which conflicts with the newly added Ruby 4.0 tags. Update the
existing latest entry in the ruby-rhel imagestream so its from.name resolves to
the Ruby 4.0 UBI 9 image, and make sure the latest metadata and annotations
remain consistent with the new major version. Use the existing 4.0-ubi9 tag
definition as the reference for the correct image source.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: cba704eb-14ad-4219-ad2d-7d1cd7ecc861
📒 Files selected for processing (24)
assets/operator/ocp-aarch64/nodejs/imagestreams/nodejs-rhel-aarch64.jsonassets/operator/ocp-aarch64/perl/imagestreams/perl-rhel-aarch64.jsonassets/operator/ocp-aarch64/php/imagestreams/php-rhel-aarch64.jsonassets/operator/ocp-aarch64/python/imagestreams/python-rhel-aarch64.jsonassets/operator/ocp-aarch64/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-aarch64/ruby/imagestreams/ruby-rhel-aarch64.jsonassets/operator/ocp-ppc64le/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-ppc64le/perl/imagestreams/perl-rhel.jsonassets/operator/ocp-ppc64le/php/imagestreams/php-rhel.jsonassets/operator/ocp-ppc64le/python/imagestreams/python-rhel.jsonassets/operator/ocp-ppc64le/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-ppc64le/ruby/imagestreams/ruby-rhel.jsonassets/operator/ocp-s390x/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-s390x/perl/imagestreams/perl-rhel.jsonassets/operator/ocp-s390x/php/imagestreams/php-rhel.jsonassets/operator/ocp-s390x/python/imagestreams/python-rhel.jsonassets/operator/ocp-s390x/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-s390x/ruby/imagestreams/ruby-rhel.jsonassets/operator/ocp-x86_64/nodejs/imagestreams/nodejs-rhel.jsonassets/operator/ocp-x86_64/perl/imagestreams/perl-rhel.jsonassets/operator/ocp-x86_64/php/imagestreams/php-rhel.jsonassets/operator/ocp-x86_64/python/imagestreams/python-rhel.jsonassets/operator/ocp-x86_64/rails/templates/rails-pgsql-persistent.jsonassets/operator/ocp-x86_64/ruby/imagestreams/ruby-rhel.json
💤 Files with no reviewable changes (8)
- assets/operator/ocp-s390x/python/imagestreams/python-rhel.json
- assets/operator/ocp-s390x/nodejs/imagestreams/nodejs-rhel.json
- assets/operator/ocp-ppc64le/nodejs/imagestreams/nodejs-rhel.json
- assets/operator/ocp-x86_64/python/imagestreams/python-rhel.json
- assets/operator/ocp-aarch64/nodejs/imagestreams/nodejs-rhel-aarch64.json
- assets/operator/ocp-ppc64le/python/imagestreams/python-rhel.json
- assets/operator/ocp-aarch64/python/imagestreams/python-rhel-aarch64.json
- assets/operator/ocp-x86_64/nodejs/imagestreams/nodejs-rhel.json
✅ Files skipped from review due to trivial changes (3)
- assets/operator/ocp-s390x/rails/templates/rails-pgsql-persistent.json
- assets/operator/ocp-aarch64/perl/imagestreams/perl-rhel-aarch64.json
- assets/operator/ocp-ppc64le/perl/imagestreams/perl-rhel.json
🚧 Files skipped from review as they are similar to previous changes (9)
- assets/operator/ocp-ppc64le/rails/templates/rails-pgsql-persistent.json
- assets/operator/ocp-s390x/perl/imagestreams/perl-rhel.json
- assets/operator/ocp-x86_64/rails/templates/rails-pgsql-persistent.json
- assets/operator/ocp-ppc64le/php/imagestreams/php-rhel.json
- assets/operator/ocp-x86_64/php/imagestreams/php-rhel.json
- assets/operator/ocp-aarch64/php/imagestreams/php-rhel-aarch64.json
- assets/operator/ocp-aarch64/rails/templates/rails-pgsql-persistent.json
- assets/operator/ocp-x86_64/perl/imagestreams/perl-rhel.json
- assets/operator/ocp-s390x/php/imagestreams/php-rhel.json
Comment on lines
+100
to
+120
| { | ||
| "name": "4.0-ubi9", | ||
| "annotations": { | ||
| "description": "Build and run Ruby 4.0 applications on UBI 9. For more information about using this builder image, including OpenShift considerations, see https://github.com/sclorg/s2i-ruby-container/blob/master/4.0/README.md.", | ||
| "iconClass": "icon-ruby", | ||
| "openshift.io/display-name": "Ruby 4.0 (UBI 9)", | ||
| "openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "sampleRepo": "https://github.com/sclorg/ruby-ex.git", | ||
| "tags": "builder,ruby", | ||
| "version": "4.0" | ||
| }, | ||
| "from": { | ||
| "kind": "DockerImage", | ||
| "name": "registry.redhat.io/ubi9/ruby-40:latest" | ||
| }, | ||
| "generation": null, | ||
| "importPolicy": {}, | ||
| "referencePolicy": { | ||
| "type": "Local" | ||
| } | ||
| }, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Repoint latest to Ruby 4.0.
These new tags add Ruby 4.0, but latest still advertises and resolves to 3.3-ubi9 on Lines 164-176. That leaves default consumers on the previous major and contradicts the warning text that latest tracks major-version updates.
Also applies to: 142-162
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/operator/ocp-aarch64/ruby/imagestreams/ruby-rhel-aarch64.json` around
lines 100 - 120, The new Ruby 4.0 imagestream entry should also update the
default `latest` alias so it points to Ruby 4.0 instead of still resolving to
`3.3-ubi9`. Adjust the `latest` image definition in `ruby-rhel-aarch64.json`
alongside the existing 4.0-ubi9 entry so the default tag and its annotations
consistently track the new major version, matching the `latest` behavior used by
consumers.
Comment on lines
+100
to
+120
| { | ||
| "name": "4.0-ubi9", | ||
| "annotations": { | ||
| "description": "Build and run Ruby 4.0 applications on UBI 9. For more information about using this builder image, including OpenShift considerations, see https://github.com/sclorg/s2i-ruby-container/blob/master/4.0/README.md.", | ||
| "iconClass": "icon-ruby", | ||
| "openshift.io/display-name": "Ruby 4.0 (UBI 9)", | ||
| "openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "sampleRepo": "https://github.com/sclorg/ruby-ex.git", | ||
| "tags": "builder,ruby", | ||
| "version": "4.0" | ||
| }, | ||
| "from": { | ||
| "kind": "DockerImage", | ||
| "name": "registry.redhat.io/ubi9/ruby-40:latest" | ||
| }, | ||
| "generation": null, | ||
| "importPolicy": {}, | ||
| "referencePolicy": { | ||
| "type": "Local" | ||
| } | ||
| }, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Repoint latest to Ruby 4.0.
These new tags add Ruby 4.0, but latest still advertises and resolves to 3.3-ubi9 on Lines 164-176. That leaves default consumers on the previous major and contradicts the warning text that latest tracks major-version updates.
Also applies to: 142-162
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/operator/ocp-ppc64le/ruby/imagestreams/ruby-rhel.json` around lines
100 - 120, The Ruby imagestream still leaves the latest tag pointing at the
older 3.3 UBI 9 image instead of the new Ruby 4.0 release. Update the latest
entry in ruby-rhel.json so its from.name resolves to the Ruby 4.0 UBI 9 Docker
image, and make sure the related latest annotations stay consistent with the
existing 4.0-ubi9 and 3.3-ubi9 definitions.
Comment on lines
+100
to
+120
| { | ||
| "name": "4.0-ubi9", | ||
| "annotations": { | ||
| "description": "Build and run Ruby 4.0 applications on UBI 9. For more information about using this builder image, including OpenShift considerations, see https://github.com/sclorg/s2i-ruby-container/blob/master/4.0/README.md.", | ||
| "iconClass": "icon-ruby", | ||
| "openshift.io/display-name": "Ruby 4.0 (UBI 9)", | ||
| "openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "sampleRepo": "https://github.com/sclorg/ruby-ex.git", | ||
| "tags": "builder,ruby", | ||
| "version": "4.0" | ||
| }, | ||
| "from": { | ||
| "kind": "DockerImage", | ||
| "name": "registry.redhat.io/ubi9/ruby-40:latest" | ||
| }, | ||
| "generation": null, | ||
| "importPolicy": {}, | ||
| "referencePolicy": { | ||
| "type": "Local" | ||
| } | ||
| }, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Repoint latest to Ruby 4.0.
These new tags add Ruby 4.0, but latest still advertises and resolves to 3.3-ubi9 on Lines 164-176. That leaves default consumers on the previous major and contradicts the warning text that latest tracks major-version updates.
Also applies to: 142-162
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/operator/ocp-s390x/ruby/imagestreams/ruby-rhel.json` around lines 100
- 120, Update the Ruby imagestream entry for the latest tag so it points to the
new Ruby 4.0 UBI 9 image instead of the current 3.3 target; adjust the `latest`
mapping in `ruby-rhel.json` consistently with the new `4.0-ubi9` entry so
default consumers resolve to Ruby 4.0. Use the `name: latest` and `from` blocks
in the imagestream definition to locate and update the correct tag target.
Comment on lines
+100
to
+120
| { | ||
| "name": "4.0-ubi9", | ||
| "annotations": { | ||
| "description": "Build and run Ruby 4.0 applications on UBI 9. For more information about using this builder image, including OpenShift considerations, see https://github.com/sclorg/s2i-ruby-container/blob/master/4.0/README.md.", | ||
| "iconClass": "icon-ruby", | ||
| "openshift.io/display-name": "Ruby 4.0 (UBI 9)", | ||
| "openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "sampleRepo": "https://github.com/sclorg/ruby-ex.git", | ||
| "tags": "builder,ruby", | ||
| "version": "4.0" | ||
| }, | ||
| "from": { | ||
| "kind": "DockerImage", | ||
| "name": "registry.redhat.io/ubi9/ruby-40:latest" | ||
| }, | ||
| "generation": null, | ||
| "importPolicy": {}, | ||
| "referencePolicy": { | ||
| "type": "Local" | ||
| } | ||
| }, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Repoint latest to Ruby 4.0.
These new tags add Ruby 4.0, but latest still advertises and resolves to 3.3-ubi9 on Lines 164-176. That leaves default consumers on the previous major and contradicts the warning text that latest tracks major-version updates.
Also applies to: 142-162
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/operator/ocp-x86_64/ruby/imagestreams/ruby-rhel.json` around lines 100
- 120, The imagestream still points the latest tag to the Ruby 3.3 UBI 9 image,
which conflicts with the newly added Ruby 4.0 tags. Update the existing latest
entry in the ruby-rhel imagestream so its from.name resolves to the Ruby 4.0 UBI
9 image, and make sure the latest metadata and annotations remain consistent
with the new major version. Use the existing 4.0-ubi9 tag definition as the
reference for the correct image source.
Contributor
|
@aroyoredhat: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncing the latest supported OCP samples from the library.
Created using https://github.com/aroyoredhat/trigger-test-samples-build
Summary by CodeRabbit
New Features
Bug Fixes