CORENET-7399: Expand golangci-lint configuration with comprehensive linter set by tpantelis · Pull Request #3164 · openshift/cluster-network-operator

tpantelis · 2026-09-15T15:55:14Z

Enabled most of the available linters covering code quality, bugs, performance, and style issues. Each linter is documented with its purpose and disabled linters are documented with a reason for exclusion (e.g., high noise-to-signal ratio, overly pedantic rules, or inapplicable to this codebase).

Also added exclusion rules to suppress false positives in specific contexts, particularly for test files and subjective style preferences.

Current violations were addressed in individual commits.

coderabbitai · 2026-09-15T15:55:23Z

Important

Review skipped

Too many files!

This PR contains 101 files, which is 1 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: cd1fbdea-71ec-4032-969b-81ac011d23f5

📥 Commits

Reviewing files that changed from the base of the PR and between 61de77e and 50c0b13.

⛔ Files ignored due to path filters (8)

vendor/github.com/stretchr/testify/require/doc.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/stretchr/testify/require/forward_requirements.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/stretchr/testify/require/require.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/stretchr/testify/require/require.go.tmpl is excluded by !vendor/**, !**/vendor/**
vendor/github.com/stretchr/testify/require/require_forward.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/stretchr/testify/require/require_forward.go.tmpl is excluded by !vendor/**, !**/vendor/**
vendor/github.com/stretchr/testify/require/requirements.go is excluded by !vendor/**, !**/vendor/**
vendor/modules.txt is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (101)

.golangci.yaml
cmd/cluster-network-check-target/main.go
cmd/cluster-network-operator/main.go
cmd/cluster-network-operator/mtu_probe.go
pkg/apply/apply.go
pkg/client/client.go
pkg/client/fake/fake_client.go
pkg/client/list_pager.go
pkg/client/operatorclient.go
pkg/client/types.go
pkg/cmd/checkendpoints/cmd.go
pkg/cmd/checkendpoints/controller/backoff_recorder.go
pkg/cmd/checkendpoints/controller/backoff_recorder_test.go
pkg/cmd/checkendpoints/controller/connection_checker.go
pkg/cmd/checkendpoints/controller/connection_checker_test.go
pkg/cmd/checkendpoints/controller/metrics.go
pkg/cmd/checkendpoints/controller/pod_network_connectivity_check_controller.go
pkg/cmd/checkendpoints/controller/updates_manager.go
pkg/cmd/checkendpoints/controller/updates_manager_test.go
pkg/cmd/checkendpoints/operatorcontrolplane/podnetworkconnectivitycheck/v1alpha1helpers/helpers_test.go
pkg/cmd/checkendpoints/trace/latency.go
pkg/controller/clusterconfig/clusterconfig_controller.go
pkg/controller/configmap_ca_injector/controller.go
pkg/controller/connectivitycheck/connectivity_check_controller.go
pkg/controller/connectivitycheck/connectivity_check_template.go
pkg/controller/dashboards/dashboard_controller.go
pkg/controller/egress_router/egress_router_controller.go
pkg/controller/eventrecorder/event_recorder.go
pkg/controller/infrastructureconfig/infrastructureconfig_controller.go
pkg/controller/infrastructureconfig/sync_specstatus.go
pkg/controller/infrastructureconfig/sync_specstatus_test.go
pkg/controller/infrastructureconfig/sync_vips.go
pkg/controller/infrastructureconfig/sync_vips_test.go
pkg/controller/infrastructureconfig/validations.go
pkg/controller/ingressconfig/ingressconfig_controller.go
pkg/controller/ingressconfig/mocks_test.go
pkg/controller/observability/observability_controller.go
pkg/controller/operconfig/cluster.go
pkg/controller/operconfig/mtu_probe.go
pkg/controller/operconfig/mtu_probe_test.go
pkg/controller/operconfig/operconfig_controller.go
pkg/controller/operconfig/previous.go
pkg/controller/pki/pki_controller.go
pkg/controller/proxyconfig/controller.go
pkg/controller/proxyconfig/controller_test.go
pkg/controller/proxyconfig/status.go
pkg/controller/proxyconfig/validation.go
pkg/controller/signer/signer-controller.go
pkg/controller/signer/signer.go
pkg/controller/signer/signer_test.go
pkg/controller/statusmanager/kube.go
pkg/controller/statusmanager/machineconfig_status.go
pkg/controller/statusmanager/machineconfig_watcher.go
pkg/controller/statusmanager/pod_status.go
pkg/controller/statusmanager/pod_watcher.go
pkg/controller/statusmanager/status_manager.go
pkg/controller/statusmanager/status_manager_test.go
pkg/controller/tls/tls_controller.go
pkg/hypershift/hypershift.go
pkg/hypershift/hypershift_test.go
pkg/names/names.go
pkg/network/additional_networks.go
pkg/network/bootstrap.go
pkg/network/bootstrap_test.go
pkg/network/cluster_config.go
pkg/network/cluster_config_test.go
pkg/network/kube_proxy.go
pkg/network/kube_proxy_test.go
pkg/network/multi_network_policy.go
pkg/network/multi_network_policy_test.go
pkg/network/multus.go
pkg/network/multus_admission_controller.go
pkg/network/multus_admission_controller_test.go
pkg/network/multus_ipam.go
pkg/network/multus_test.go
pkg/network/network_metrics_test.go
pkg/network/node_identity.go
pkg/network/node_identity_test.go
pkg/network/ovn_kubernetes.go
pkg/network/ovn_kubernetes_dpu_host_test.go
pkg/network/ovn_kubernetes_test.go
pkg/network/render.go
pkg/network/render_test.go
pkg/network/testutil_test.go
pkg/network/tls.go
pkg/network/tls_test.go
pkg/operator/operator.go
pkg/platform/platform.go
pkg/render/render.go
pkg/util/ip/addr.go
pkg/util/ip/addr_test.go
pkg/util/k8s/dynamicrestmapper.go
pkg/util/k8s/kubeproxy.go
pkg/util/k8s/unstructured.go
pkg/util/k8s/unstructured_test.go
pkg/util/proxyconfig/no_proxy.go
pkg/util/util.go
pkg/util/validation/network.go
pkg/util/validation/network_test.go
pkg/util/validation/trustbundle.go
pkg/version/version.go

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands.}

openshift-merge-bot · 2026-09-15T15:55:31Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci · 2026-09-15T15:55:45Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tpantelis
Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

danwinship · 2026-09-15T18:08:27Z

+					_, found := ovnkubeController.Resources.Requests[resourceName]
+					g.Expect(found).To(BeFalse(), "resource request should not be set")
+					_, found = ovnkubeController.Resources.Limits[resourceName]
+					g.Expect(found).To(BeFalse(), "resource limit should not be set")


I disagree with this rewrite in theory, but also tc.mgmtPortResourceName is always non-empty anyway, so just remove the if tc.mgmtPortResourceName != "" part and it's good

The rewrite saves indentation. There is one case on line 490 where tc.mgmtPortResourceName is empty.

oh, missed that.

So, I prefer the original (though not enough to want to //nolint it), because it expresses the actual logic better. The rewritten version is not especially explicit about the fact that we only care about tc.mgmtPortResourceName when tc.expectResource is false.

danwinship · 2026-09-15T18:53:03Z

 			}
+
+			fmt.Printf("Failed to write ConfigMap: %v", err)
+			time.Sleep(10 * time.Second)


I don't agree that these rewrites improve the code, though I don't think any of them make it worse either. But if you end up dropping revive entirely (or can configure it to avoid these rewrites specifically), then I'd drop this commit, to save on unnecessary backport conflicts.

It saves unnecessary indentation which is purely style preference. revive has some opinionated, subjective style rules like this one (superfluous-else) but it also has a lot of useful rules as well that flagged other issues. I think we should keep revive but I disabled superfluous-else (and indent-error-flow).

danwinship · 2026-09-15T18:57:36Z

 		{
 			name: "RSA PKCS1 private key",
 			pemData: func(t *testing.T) []byte {
+				t.Helper()


This seems wrong; if a test fails inside a helper defined inside a test case, then presumably we want to see that more specific failure location.

I was on the fence about this linter. I'll ignore it here but I'm also OK with disabling the linter.

I like how it pointed out when external helper functions were missing t.Helper(). But it seems like a bug to be flagging internal helpers.

danwinship · 2026-09-15T19:12:58Z

(overall: yay!)

Adds context.Context parameters to functions throughout the codebase and replaces context.TODO() calls with properly inherited context. This fixes violations reported by the `contextcheck` linter allowing it to be enabled. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

These were flagged by the `dupword` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Replaces type assertions and direct error comparisons with the proper Go 1.13+ error handling functions to correctly handle wrapped errors. This ensures error checking works correctly even when errors are wrapped with additional context. These were flagged by the `errorlint` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Replace non-wrapping format verbs (%v, %s) with %w in fmt.Errorf calls throughout the codebase to ensure proper error wrapping compatible with Go 1.13+ error handling (errors.As, errors.Is). These were flagged by the `errorlint` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Move logs.FlushLogs() from deferred call to explicit call before the error check and os.Exit(). This ensures logs are always flushed before the process exits, since deferred functions do not run when os.Exit() is called. These was flagged by the `gocritic` linter (exitAfterDefer). Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Rename capitalized local variables to follow Go naming conventions. Local variables and function parameters should start with lowercase letters per Go style guidelines. These were flagged by the `gocritic` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Replace nested 'else { if cond {} }' with 'else if cond {}' for better readability and cleaner code structure. This was flagged by the `gocritic` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

...with an if statement for better readability and simpler code structure. A switch with only one case and no default is unnecessarily complex and should be written as a simple if statement. This was flagged by the `gocritic` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Use slices.Clone() when appending to baseClientObjs to avoid potential slice aliasing issues. This ensures each test gets an independent copy of the base objects rather than risking shared underlying arrays. This was flagged by the `gocritic` linter (appendAssign). Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

This was flagged by the `godoclint` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Add nolint directive for plain text response with network addresses. This was flagged by the `gosec` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

openshift-ci-robot · 2026-09-17T12:16:55Z

@tpantelis: This pull request references CORENET-7399 which is a valid jira issue.

Details

In response to this:

Enabled most of the available linters covering code quality, bugs, performance, and style issues. Each linter is documented with its purpose and disabled linters are documented with a reason for exclusion (e.g., high noise-to-signal ratio, overly pedantic rules, or inapplicable to this codebase).

Also added exclusion rules to suppress false positives in specific contexts, particularly for test files and subjective style preferences.

Current violations were addressed in individual commits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Configure 30-second read and write timeouts to prevent resource exhaustion from slow or malicious clients. This was flagged by the `gosec` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

InsecureSkipVerify is intentional - this tool checks endpoint connectivity, not certificate validity. It needs to connect to arbitrary cluster endpoints with self-signed or internal certificates. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Name unnamed parameters in interfaces for better documentation. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Convert for loops with unused iteration variables to use the range-over-int syntax for clarity and consistency with modern Go patterns. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

This was flagged by the `modernize` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Make the return statement explicit for better code clarity in this 91-line function. Named return parameters document the API; explicit returns remove ambiguity about what's being returned. This was flagged by the `nakedret` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Return the marshal error instead of silently returning nil when json.Marshal fails. This was flagged by the `nilerr` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Replace tls.Conn.Handshake() with HandshakeContext(ctx) and http.NewRequest() with http.NewRequestWithContext() for proper timeout and cancellation support. This was flagged by the `noctx` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

...and eliminate unnecessary intermediate slice variables by returning results directly. These were flagged by the `prealloc` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

This was flagged by the `predeclared` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Add explanatory comments to suppress promlinter warnings about metric naming conventions. While the linter is correct that counters should end with _total and labels should use snake_case, renaming these metrics would be a breaking change for existing monitoring dashboards and alerts. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Change Reconcile method from value receiver to pointer receiver for consistency with other methods and to properly implement the reconcile.Reconciler interface. This was flagged by the `recvcheck` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Either rename them to underscore if they're required in the signature or removing them from function signatures where they are not used. These were flagged by the `revive` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

...according to official Go style guidelines and flagged by the `revive` linter: - don't use ALL_CAPS in Go names; use CamelCase - don't use underscores in Go names Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

None of the contained functions are used anymore. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

...where the type can be inferred from the assigned value. These were flagged by the `revive` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

- Use assert.Equal instead of assert.EqualValues for same-type comparisons - Use require.NoError instead of assert.NoError for error assertions - Use assert.False/assert.True instead of assert.Equal These were flagged by the `testifylint` linter. Signed-off-by: Tom Pantelis <tpantel@redhat.com>

Add t.Helper() calls to test helper functions so errors are reported at the caller's line, not inside the helper function itself. This improves test failure diagnostics and line number accuracy. These were flagged by the `thelper` linter. Signed-off-by: Tom Pantelis <tpantel@redhat.com>

In some cases, all callers pass the same value to a function param and the param can be removed. Similarly with a function that always returns the same value (eg a nil error). These were flagged by the `unparam` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com> # Conflicts: # pkg/controller/proxyconfig/validation.go

This was flagged by the `usestdlibvars` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Clean up whitespace by removing blank lines immediately after opening braces and before closing braces in functions, if statements, for loops, and other code blocks. These were flagged by the `whitespace` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

...to align with recommendations for test readability. - Use BeEmpty() instead of HaveLen(0) for length assertions - Use Expect(err).NotTo(HaveOccurred()) or Expect(...).To(Succeed()) for cleaner error checks These were flagged by the `ginkgolinter` linter. Signed-off-by: Tom Pantelis <tpantel@redhat.com>

Add nolint directive for math/rand usage in serial number generation. This follows the intentional library-go pattern where serial numbers require uniqueness but not cryptographic unpredictability. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Enabled most of the available linters covering code quality, bugs, performance, and style issues. Each linter is documented with its purpose and disabled linters are documented with a reason for exclusion (e.g., high noise-to-signal ratio, overly pedantic rules, or inapplicable to this codebase). Also added exclusion rules to suppress false positives in specific contexts, particularly for test files and subjective style preferences. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

tpantelis · 2026-09-21T15:52:47Z

/retest

openshift-ci · 2026-09-21T21:35:06Z

@tpantelis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-secondary-encap	`f29cb33`	link	false	`/test e2e-metal-ipi-ovn-secondary-encap`
ci/prow/security	`50c0b13`	link	true	`/test security`
ci/prow/5.1-upgrade-from-stable-5.0-e2e-azure-ovn-upgrade	`50c0b13`	link	false	`/test 5.1-upgrade-from-stable-5.0-e2e-azure-ovn-upgrade`
ci/prow/5.1-upgrade-from-stable-5.0-e2e-aws-ovn-upgrade	`50c0b13`	link	false	`/test 5.1-upgrade-from-stable-5.0-e2e-aws-ovn-upgrade`
ci/prow/5.1-upgrade-from-stable-5.0-e2e-gcp-ovn-upgrade	`50c0b13`	link	false	`/test 5.1-upgrade-from-stable-5.0-e2e-gcp-ovn-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tpantelis · 2026-09-22T12:56:25Z

/test security

danwinship · 2026-09-22T20:37:20Z

+const MultusValidatingWebhook = "multus.openshift.io"

-// ADDL_TRUST_BUNDLE_CONFIGMAP_NS is the namespace for one or more
+// AdditionalTrustBundleConfigMapNS is the namespace for one or more


The "NS" is uglier now that the rest of the name is titlecase... can you change them all to "Namespace"?

danwinship · 2026-09-22T20:48:26Z

 }

 func TestDecodePrivateKey(t *testing.T) {
+	//nolint:thelper // Helper functions are inside test cases


I had only mentioned this in one place, but there are lots of places where I feel like it was suggesting this incorrectly. Like, every call to testTLSArgRendering (and testTLSArgRendering itself). And I don't like marking each one //nolint, because then the next time someone adds something using testTLSArgRendering, the linter will tell them to use t.Helper(), and the reviewer may not catch the fact that it's wrong.

So we should drop this linter, because it has too many false positives. (And, also, note that the failure mode of someone failing to use t.Helper() where they should is just that unit test error output isn't as helpful as it could have been, and it can always be fixed later.)

(I'm fine keeping the "good" t.Helper() additions if you want, but I haven't gone through every suggestion to figure out which ones would actually make the error output better and which would make it worse, so you'd have to do that.)

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2026

openshift-ci Bot requested review from arghosh93 and creydr September 15, 2026 15:55

tpantelis force-pushed the add_linters branch from c5a7166 to c42f15d Compare September 15, 2026 16:49

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2026

danwinship reviewed Sep 15, 2026

View reviewed changes

tpantelis force-pushed the add_linters branch from c42f15d to f29cb33 Compare September 16, 2026 17:24

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2026

tpantelis added 12 commits September 16, 2026 13:26

Remove duplicate words in code comments

39ffa27

These were flagged by the `dupword` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Use inline 'else if' in DPU host test

38bacec

Replace nested 'else { if cond {} }' with 'else if cond {}' for better readability and cleaner code structure. This was flagged by the `gocritic` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

godoc should start with symbol name

e793da2

This was flagged by the `godoclint` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Group standard lib imports at the top

2053534

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Suppress G705 XSS false positive in health check endpoint

43ec680

Add nolint directive for plain text response with network addresses. This was flagged by the `gosec` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

tpantelis force-pushed the add_linters branch from f29cb33 to 1ca7e38 Compare September 16, 2026 17:27

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2026

tpantelis changed the title ~~Expand golangci-lint configuration with comprehensive linter set~~ CORENET-7399: Expand golangci-lint configuration with comprehensive linter set Sep 17, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2026

tpantelis force-pushed the add_linters branch from 1ca7e38 to 63705b9 Compare September 17, 2026 12:19

tpantelis added 24 commits September 17, 2026 10:50

Add timeouts to HTTP server in network check target

0958c97

Configure 30-second read and write timeouts to prevent resource exhaustion from slow or malicious clients. This was flagged by the `gosec` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Add parameter names to interface methods

03f67a0

Name unnamed parameters in interfaces for better documentation. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Use Go 1.22+ integer range loops

fdbd208

Convert for loops with unused iteration variables to use the range-over-int syntax for clarity and consistency with modern Go patterns. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Replace interface{} with any

f2a5cfd

This was flagged by the `modernize` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Fix error handling in getAllowedDestinationsConfigJSON

bc5a322

Return the marshal error instead of silently returning nil when json.Marshal fails. This was flagged by the `nilerr` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Use context-aware HTTP methods

972acc1

Replace tls.Conn.Handshake() with HandshakeContext(ctx) and http.NewRequest() with http.NewRequestWithContext() for proper timeout and cancellation support. This was flagged by the `noctx` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Preallocate slices where needed

56a270b

...and eliminate unnecessary intermediate slice variables by returning results directly. These were flagged by the `prealloc` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Rename variables to avoid shadowing predeclared identifiers

0dfc6ae

This was flagged by the `predeclared` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Address unused function parameter

f146763

Either rename them to underscore if they're required in the signature or removing them from function signatures where they are not used. These were flagged by the `revive` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Use consistent variable and constant naming conventions

a748404

...according to official Go style guidelines and flagged by the `revive` linter: - don't use ALL_CAPS in Go names; use CamelCase - don't use underscores in Go names Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Remove pkg/client/list_pager.go

50b5002

None of the contained functions are used anymore. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Remove explicit types from variable declarations

7ec0d80

...where the type can be inferred from the assigned value. These were flagged by the `revive` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Use http.MethodGet constant

d96d16a

This was flagged by the `usestdlibvars` linter. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

tpantelis force-pushed the add_linters branch from 63705b9 to 50c0b13 Compare September 17, 2026 14:51

danwinship reviewed Sep 22, 2026

View reviewed changes

Conversation

tpantelis commented Sep 15, 2026

Uh oh!

coderabbitai Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-merge-bot Bot commented Sep 15, 2026

Uh oh!

openshift-ci Bot commented Sep 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

danwinship commented Sep 15, 2026

Uh oh!

openshift-ci-robot commented Sep 17, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tpantelis commented Sep 21, 2026

Uh oh!

openshift-ci Bot commented Sep 21, 2026

Uh oh!

tpantelis commented Sep 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Sep 15, 2026 •

edited

Loading

openshift-ci-robot commented Sep 17, 2026 •

edited by openshift-ci Bot

Loading