Skip to content

feat: Add TrustManager API types for trust-manager integration (EP#1914) - #497

Open
openshift-app-platform-shift[bot] wants to merge 1 commit into
cert-manager-1.18from
feature/api-types-1914-1789642468
Open

openshift-app-platform-shift[bot] wants to merge 1 commit into
cert-manager-1.18from
feature/api-types-1914-1789642468

Conversation

@openshift-app-platform-shift

Copy link
Copy Markdown

Summary

  • Adds TrustManager CRD (trustmanagers.operator.openshift.io/v1alpha1) to support deploying and managing the trust-manager operand as described in EP#1914
  • Adds TrustManager FeatureGate (TechPreview, default disabled) to gate the trust-manager controller
  • Includes integration test suite covering validation rules, singleton enforcement, immutability, and cross-field CEL validation

New Types

  • TrustManager: Cluster-scoped singleton (name must be cluster) with spec/status
  • TrustManagerConfig: logLevel, logFormat, trustNamespace (immutable), secretTargets, filterExpiredCertificates, defaultCAPackage, resources, affinity, tolerations, nodeSelector
  • SecretTargetsConfig: policy (Disabled/Custom) with authorizedSecrets and CEL validation
  • DefaultCAPackageConfig: policy (Enabled/Disabled) for OpenShift trusted CA bundle injection
  • TrustManagerControllerConfig: labels and annotations for operator-created resources
  • Enum types: FilterExpiredCertificatesPolicy, SecretTargetsPolicy, DefaultCAPackagePolicy

Generated Artifacts

  • Deep copy functions (zz_generated.deepcopy.go)
  • CRD manifest (config/crd/bases/operator.openshift.io_trustmanagers.yaml)
  • Apply configurations, clientset, informers, and listers

Test plan

  • Verify CRD schema matches EP specification
  • Verify singleton validation rejects names other than cluster
  • Verify trustNamespace immutability
  • Verify secretTargets CEL cross-field validation
  • Verify enum validation for all policy fields
  • Run make generate && make manifests && make build to verify build

🤖 Generated with Claude Code

Adds the TrustManager CRD (trustmanagers.operator.openshift.io/v1alpha1)
to support deploying and managing the trust-manager operand. This
implements the API types defined in enhancement proposal #1914 (CM-830).

Key additions:
- TrustManager type with singleton validation (name must be 'cluster')
- TrustManagerConfig: logLevel, logFormat, trustNamespace (immutable),
  secretTargets, filterExpiredCertificates, defaultCAPackage, scheduling
- SecretTargetsConfig with CEL cross-field validation rules
- DefaultCAPackageConfig for OpenShift trusted CA bundle injection
- TrustManager FeatureGate (TechPreview, default disabled)
- Generated deepcopy, clientset, informers, listers, and CRD manifest
- Integration test suite for validation rules

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: db016dd9-8348-484a-9cab-60ee4263d407

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-app-platform-shift[bot]
Once this PR has been reviewed and has the lgtm label, please assign mytreya-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 17, 2026
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Hi @openshift-app-platform-shift[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants