Skip to content

CM-1367: Add TrustManager filterNonCACerts API #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arun717 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

CM-1367: Add TrustManager filterNonCACerts API #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8a64905
CM-1367: Add TrustManager filterNonCACerts API.
arun717 Sep 10, 2026
4ea3f27
CM-1367: Stop echoing TrustManager spec into status.
arun717 Sep 10, 2026
df12e17
CM-1367: Add webhook TLS duration and approver-policy, reuse Mode for…
arun717 Sep 17, 2026
39f02b7
CM-1367: Refresh generated applyconfigurations and gofmt.
arun717 Sep 18, 2026
c6ada8a
CM-1367: Commit generated bundle CSV RBAC and TrustManager webhookTLS…
arun717 Sep 18, 2026
e9c3956
CM-1367: Fix TrustManager webhook certificate duration and approver-p…
arun717 Sep 28, 2026
884a652
CM-1367: Add TrustManager webhook cert-manager configuration.
arun717 Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 134 additions & 0 deletions api/operator/v1alpha1/tests/trustmanagers.operator.openshift.io/trustmanager.testsuite.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled

- name: Should not allow creating TrustManager with invalid name
resourceName: invalid-name
Expand Down Expand Up @@ -52,6 +53,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled

- name: Should not allow logLevel below minimum
resourceName: cluster
Expand Down Expand Up @@ -93,6 +95,7 @@ tests:
logFormat: json
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled

- name: Should not allow invalid logFormat
resourceName: cluster
Expand Down Expand Up @@ -124,6 +127,7 @@ tests:
logFormat: text
trustNamespace: custom-namespace
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled

# ==========================================
# FilterExpiredCertificates Tests
Expand All @@ -136,6 +140,7 @@ tests:
spec:
trustManagerConfig:
filterExpiredCertificates: Enabled
filterNonCACerts: Disabled
expected: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
Expand All @@ -145,6 +150,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Enabled
filterNonCACerts: Disabled

- name: Should not allow invalid filterExpiredCertificates value
resourceName: cluster
Expand All @@ -154,8 +160,41 @@ tests:
spec:
trustManagerConfig:
filterExpiredCertificates: Invalid
filterNonCACerts: Disabled
expectedError: "filterExpiredCertificates"

# ==========================================
# FilterNonCACerts Tests
# ==========================================
- name: Should create with filterNonCACerts Enabled
resourceName: cluster
initial: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
spec:
trustManagerConfig:
filterNonCACerts: Enabled
expected: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
spec:
trustManagerConfig:
logLevel: 1
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Enabled

- name: Should not allow invalid filterNonCACerts value
resourceName: cluster
initial: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
spec:
trustManagerConfig:
filterNonCACerts: Invalid
expectedError: "filterNonCACerts"

# ==========================================
# DefaultCAPackage Tests
# ==========================================
Expand All @@ -177,6 +216,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
defaultCAPackage:
policy: Enabled

Expand Down Expand Up @@ -215,6 +255,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
secretTargets:
policy: Custom
authorizedSecrets:
Expand Down Expand Up @@ -282,6 +323,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
resources:
requests:
cpu: 100m
Expand Down Expand Up @@ -315,6 +357,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
Expand Down Expand Up @@ -345,6 +388,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
tolerations:
- key: node-role.kubernetes.io/master
operator: Exists
Expand All @@ -368,6 +412,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
nodeSelector:
kubernetes.io/os: linux

Expand All @@ -393,6 +438,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
controllerConfig:
labels:
app.kubernetes.io/managed-by: cert-manager-operator
Expand All @@ -416,10 +462,63 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
controllerConfig:
annotations:
custom-annotation: custom-value

# ==========================================
# WebhookTLS certificateDuration Tests
# ==========================================
- name: Should create with a valid webhookTLS certificateDuration
resourceName: cluster
initial: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
spec:
trustManagerConfig:
webhookTLS:
certManager:
certificateDuration: 8760h
expected: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
spec:
trustManagerConfig:
logLevel: 1
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
webhookTLS:
certManager:
certificateDuration: 8760h

- name: Should not allow a malformed webhookTLS certificateDuration
resourceName: cluster
initial: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
spec:
trustManagerConfig:
webhookTLS:
certManager:
certificateDuration: not-a-duration
expectedError: "certificateDuration"

- name: Should not allow an RSA private key with an ECDSA size
resourceName: cluster
initial: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
spec:
trustManagerConfig:
webhookTLS:
certManager:
privateKeyAlgorithm: RSA
privateKeySize: 256
expectedError: "privateKeySize"

# ==========================================
# Immutability Tests (onUpdate)
# ==========================================
Expand Down Expand Up @@ -463,6 +562,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled

- name: Should allow updating logFormat
resourceName: cluster
Expand All @@ -487,6 +587,7 @@ tests:
logFormat: json
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled

- name: Should allow updating filterExpiredCertificates
resourceName: cluster
Expand All @@ -496,12 +597,14 @@ tests:
spec:
trustManagerConfig:
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
updated: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
spec:
trustManagerConfig:
filterExpiredCertificates: Enabled
filterNonCACerts: Disabled
expected: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
Expand All @@ -511,6 +614,32 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Enabled
filterNonCACerts: Disabled

- name: Should allow updating filterNonCACerts
resourceName: cluster
initial: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
spec:
trustManagerConfig:
filterNonCACerts: Disabled
updated: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
spec:
trustManagerConfig:
filterNonCACerts: Enabled
expected: |
apiVersion: operator.openshift.io/v1alpha1
kind: TrustManager
spec:
trustManagerConfig:
logLevel: 1
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Enabled

- name: Should allow updating defaultCAPackage policy
resourceName: cluster
Expand All @@ -537,6 +666,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
defaultCAPackage:
policy: Enabled

Expand Down Expand Up @@ -567,6 +697,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
secretTargets:
policy: Custom
authorizedSecrets:
Expand Down Expand Up @@ -602,6 +733,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
secretTargets:
policy: Custom
authorizedSecrets:
Expand Down Expand Up @@ -635,6 +767,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
secretTargets:
policy: Disabled

Expand Down Expand Up @@ -710,6 +843,7 @@ tests:
logFormat: text
trustNamespace: cert-manager
filterExpiredCertificates: Disabled
filterNonCACerts: Disabled
secretTargets:
policy: Custom
authorizedSecrets:
Expand Down
Loading