Conversation
|
@sujkini: This pull request references CM-1216 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sujkini The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Adds replace directive for golang.org/x/net to fix reachable CVE-2026-39821 (Critical, CVSS 9.6) in the HTTP/2 transport layer used for Kubernetes API communication. The openshift-sustaining/net fork backports the fix to the Go 1.24 dependency tree without requiring a full module upgrade. - CVE-2026-39821: golang.org/x/net/idna Punycode bypass (reachable) - CVE-2026-25681: golang.org/x/net/html parsing bypass (same module, not reachable) - CVE-2026-27136: golang.org/x/net/html parsing bypass (same module, not reachable) replace golang.org/x/net => openshift-sustaining/net@v0.50.0-sec.2 Jira: CM-1216 Signed-off-by: Sujnyan Kini <skini@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Updates operator and operand versions for cert-manager-operator v1.18.2 z-stream release. Bumps cert-manager operand from 1.18.4 to 1.18.6 and operator bundle from 1.18.1 to 1.18.2. - Updates Makefile: CERT_MANAGER_VERSION, BUNDLE_VERSION - Updates cert-manager operand manifests with v1.18.6 chart content - Updates OLM bundle manifests (CSV name, version, replaces, skipRange) - Bumps cert-manager package dependency and dependents Jira: CM-1216 Signed-off-by: Sujnyan Kini <skini@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
0a2be97 to
a4e1861
Compare
| value: 1.18.4 | ||
| value: 1.18.6 | ||
| - name: ISTIOCSR_OPERAND_IMAGE_VERSION | ||
| value: 0.14.2 |
There was a problem hiding this comment.
We have 0.14.3 available too.
There was a problem hiding this comment.
Verified that v0.14.3 fixes 5 of our 6 open istio-csr CVEs:
Dependency Upgrades in v0.14.3:
- golang.org/x/net: v0.38.0 → v0.44.0
- google.golang.org/grpc: v1.73.0 → v1.76.0
- go-jose/v4: v4.0.5 → v4.1.2
- Go toolchain: 1.24.0 → 1.25.0
CVEs Fixed:
- CM-1229: CVE-2026-42502 (x/net html Render)
- CM-1195: CVE-2026-27136 (x/net html duplicate attrs)
- CM-1189/1188/1187/1149: CVE-2026-25681 (x/net html)
- CM-1052: CVE-2026-33186 (grpc :path)
- CM-982: CVE-2026-34986 (go-jose)
Bumped in latest commit
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.20 AS builder | ||
|
|
||
| ARG RELEASE_BRANCH=v1.18.4 | ||
| ARG RELEASE_BRANCH=v1.18.6 |
There was a problem hiding this comment.
We did create a branch in downstream fork, with local bumps pkgs correct? We should be using the same release branch name instead.
There was a problem hiding this comment.
Thank you for pointing out, as pr #44 is merged, updated to release-1.18 existing branch.
|
|
||
| replace github.com/tdakkota/asciicheck => github.com/golangci/asciicheck v0.1.1 | ||
|
|
||
| replace golang.org/x/net => github.com/openshift-sustaining/net v0.50.0-sec.2 |
There was a problem hiding this comment.
Why the same changes in two different PRs? Was this branch created on top or something like that?
3b4de81 to
b340608
Compare
Updates cert-manager-istio-csr dependency to v0.14.3 which resolves 5 CVEs: - CVE-2026-42502: golang.org/x/net html Render (x/net v0.44.0) - CVE-2026-27136: golang.org/x/net html duplicate attributes (x/net v0.44.0) - CVE-2026-25681: golang.org/x/net html parsing bypass (x/net v0.44.0) - CVE-2026-33186: google.golang.org/grpc HTTP/2 :path (grpc v1.76.0) - CVE-2026-34986: go-jose signature verification (go-jose v4.1.2) Dependency upgrades in v0.14.3: - golang.org/x/net v0.38.0 → v0.44.0 - google.golang.org/grpc v1.73.0 → v1.76.0 - go-jose/v4 v4.0.5 → v4.1.2 Jira: CM-1216 Signed-off-by: Sujnyan Kini <skini@redhat.com> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Changes the RELEASE_BRANCH argument from version tag (v1.18.6) to the release branch (release-1.18) to ensure all CVE backports from PR openshift#44 are included in the build. The release-1.18 branch contains all sustaining security fixes: - replace golang.org/x/net => openshift-sustaining/net v0.50.0-sec.2 - replace google.golang.org/grpc => openshift-sustaining/grpc-go v1.75.1-sec.1 - replace golang.org/x/crypto => openshift-sustaining/crypto v0.48.0-sec.1 Using the release branch instead of version tag ensures builds include sustaining security fixes that may not be in the tag. Jira: CM-1216 Signed-off-by: Sujnyan Kini <skini@redhat.com> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
903d2f0 to
9749e54
Compare
|
/test verify |
9749e54 to
bf70657
Compare
Updates istio-csr dependency to v0.14.3 which resolves 5 CVEs by updating dependencies in the operand image: - golang.org/x/net v0.38.0 → v0.44.0 (CVE-2026-42502, CVE-2026-27136, CVE-2026-25681) - google.golang.org/grpc v1.73.0 → v1.76.0 (CVE-2026-33186) - go-jose/v4 v4.0.5 → v4.1.2 (CVE-2026-34986) Updates both config/manager and bindata manifests to keep versions in sync. Jira: CM-1216 Signed-off-by: Sujnyan Kini <skini@redhat.com> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
bf70657 to
95446c9
Compare
|
@sujkini: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Dependencies
Verification
go build ./...✅operator-sdk bundle validate✅Jira: CM-1216
Signed-off-by: Sujnyan Kini skini@redhat.com
Co-authored-by: Cursor cursoragent@cursor.com