Skip to content

feat(slack): exclude noisy workflows from failure alerts #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
divyansh42 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(slack): exclude noisy workflows from failure alerts #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/downstream/repos/operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ components:
no-image-suffix: true
- name: webhook
- name: proxy
excluded-slack-alert-workflows:
- render-olm-catalog

@pramodbindal pramodbindal Jun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution might not be required permanently.
Once SRVKP-12442 is fixed, We need to actively track the failures

patches: []
github:
update-sources: |
Expand Down
9 changes: 5 additions & 4 deletions internal/konflux/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,11 @@ type Repository struct {
Patches []Patch
NoPrefixUpstream bool `json:"no-prefix-upstream" yaml:"no-prefix-upstream"`
UsePatchBranch bool `json:"use-patch-branch" yaml:"use-patch-branch"`
Owners []string `json:"owners" yaml:"owners"`
PrefetchInput string `json:"prefetch-input" yaml:"prefetch-input"`
MinVersion string `json:"min-version" yaml:"min-version"`
MaxVersion string `json:"max-version" yaml:"max-version"`
Owners []string `json:"owners" yaml:"owners"`
ExcludedSlackWorkflows []string `json:"excluded-slack-alert-workflows" yaml:"excluded-slack-alert-workflows"`
PrefetchInput string `json:"prefetch-input" yaml:"prefetch-input"`
MinVersion string `json:"min-version" yaml:"min-version"`
MaxVersion string `json:"max-version" yaml:"max-version"`
}
type Branch struct {
Name string
Expand Down
2 changes: 1 addition & 1 deletion internal/konflux/templates/github/workflows/slack-notify-on-failure.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
jobs:
notify:
runs-on: ubuntu-latest
if: {{ "${{ github.event.workflow_run.conclusion == 'failure' }}" }}
if: {{ "${{ github.event.workflow_run.conclusion == 'failure' && github.event.workflow_run.name != 'auto-merge-upstream'" }}{{ range .ExcludedSlackWorkflows }} && github.event.workflow_run.name != '{{ . }}'{{ end }}{{ " }}" }}
steps:
- name: Send Slack notification
uses: slackapi/slack-github-action@v2.1.0
Expand Down