chore: skip github release and use gpg signed tag flow#293
Conversation
WalkthroughThis PR consolidates GitHub Actions reusable workflows from ChangesCI/CD Workflow Migration and Release Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (69.93%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
=======================================
Coverage 69.93% 69.93%
=======================================
Files 142 142
Lines 10774 10774
=======================================
Hits 7535 7535
Misses 3239 3239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the repository’s release-please configuration to stop creating GitHub Releases as part of the release-please flow, aligning with a “signed tag” release process.
Changes:
- Remove release-please GitHub Release drafting/forced tag creation settings.
- Add
skip-github-release: trueto disable GitHub Release creation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/main.yaml (1)
120-125:⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift
undraft-releasejob conflicts withskip-github-release: true.The release-please config now sets
skip-github-release: true, which means release-please no longer creates a GitHub release (not even a draft) for tagged versions. Thisundraft-releasejob exists specifically to flip an existing draft release to published. With no release created, this job has nothing to operate on and will either no-op or fail (e.g., release-not-found) on every tag push.Given the PR's stated intent to skip GitHub releases and rely on GPG-signed tags, this job appears to be leftover and should likely be removed (along with the
needs: [publish]/permissions wiring). Please confirm whetherundraft-release.ymlonopenfga/.githubtolerates a missing release before keeping it.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/main.yaml around lines 120 - 125, The undraft-release job is now obsolete because release-please is configured with skip-github-release: true so no draft release is created; remove the undraft-release job block (the undraft-release job name and its uses: openfga/.github/.github/workflows/undraft-release.yml@main plus its needs: [publish] and permissions: contents: write wiring) from the workflow, or alternatively gate it behind a check that release-please creates a release; if you prefer to keep it instead of deleting, explicitly verify call to undraft-release.yml tolerates a missing release and add a conditional input or if-check tied to the release-please behavior before keeping undraft-release and its publish dependency.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/main.yaml:
- Line 125: The reusable workflow reference "uses:
openfga/.github/.github/workflows/undraft-release.yml@main" is invalid because
the target ref doesn't contain a .github/workflows file; update the `uses:` to
point to an existing reusable workflow in the correct repo/path or pin to a
specific commit SHA—e.g., change the reference to the proper repository/path
that actually contains undraft-release.yml (or replace `@main` with the commit SHA
or valid branch on the repo that contains the workflow); ensure the `uses:`
entry is a valid reusable-workflow reference so the release pipeline can run.
---
Outside diff comments:
In @.github/workflows/main.yaml:
- Around line 120-125: The undraft-release job is now obsolete because
release-please is configured with skip-github-release: true so no draft release
is created; remove the undraft-release job block (the undraft-release job name
and its uses: openfga/.github/.github/workflows/undraft-release.yml@main plus
its needs: [publish] and permissions: contents: write wiring) from the workflow,
or alternatively gate it behind a check that release-please creates a release;
if you prefer to keep it instead of deleting, explicitly verify call to
undraft-release.yml tolerates a missing release and add a conditional input or
if-check tied to the release-please behavior before keeping undraft-release and
its publish dependency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 422a67e8-dd1d-4c87-b799-9adccb177f18
📒 Files selected for processing (4)
.github/workflows/main.yaml.github/workflows/pr-title-conventional-commit.yml.github/workflows/release-please.ymlrelease-please-config.json
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit