refactor: Make brand-sample one layer simpler#49
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 16 16
Lines 503 503
Branches 18 18
=======================================
Hits 468 468
Misses 24 24
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kdmccormick
force-pushed
the
kdmccormick/brand-simpler
branch
2 times, most recently
from
c4e2363 to
1ce0fd8
Compare
This collapses brand-sample/src into brand-sample. The extra layer did not seem to be serving a purpose. It confused me over and over again when I was debugging tutor-contrib-paragon. This also drops the Makefile and merges its on rule (build) into package.json, removing the unnecessary package.json<->Makefile indirection that was going on.
kdmccormick
force-pushed
the
kdmccormick/brand-simpler
branch
from
1ce0fd8 to
b922f6a
Compare
| @@ -1 +1,2 @@ | |||
| !dist | |||
There was a problem hiding this comment.
I think this was needed because of the top-level .gitignore in this repo. Removing it won't break anything, but if someone were to delete the dist dir and commit the removal we'd need to force-add it to get it back.
Line 13 in ccc9a1d
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Overall this makes sense. The only real benefit to having the package live in a src subdir was not having the output of builds tied to the checked-in dist.
2 participants
This collapses brand-sample/src into brand-sample. The extra layer did not seem to be serving a purpose; it actually confused me over and over again when I was copying files around to debug tutor-contrib-paragon :P
This also drops the Makefile and merges its on rule (build) into
package.json, removing the unnecessary package.json->Makefile->package.json
indirection that was going on.
No AI use.