feat!: use semicolons for TypeScript member delimiters - #297
Open
arbrandes wants to merge 1 commit into
Open
Conversation
Semicolons are the TypeScript standard, and what the linting configuration frontend-base replaced enforced. Requiring commas instead forced unrelated churn into the diff of every repository migrating to frontend-base. BREAKING CHANGE: Consumers of the shared ESLint config will see member delimiter errors after upgrading. Run `npm run lint:fix` to resolve them. Closes openedx#296 Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Aug 24, 2026
Contributor
|
well, following the discussion from here |
jesusbalderramawgu
approved these changes
Aug 24, 2026
Contributor
|
Agree, following the Typescript Standard seems the right pattern to follow 👍 |
diana-villalvazo-wgu
approved these changes
Aug 24, 2026
bradenmacdonald
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches the shared ESLint config to require semicolons rather than commas as TypeScript member delimiters, and auto-fixes the repository and test site to match.
This is a breaking change for consumers: the rule is inherited from frontend-base, so lint will fail after upgrading until
npm run lint:fixis run.Closes #296
LLM usage notice
Built with assistance from Claude.