OBPIH-8025 adjust receiving tests to new receiving ui - #104
Open
kkrawczyk123 wants to merge 3 commits into
Open
kkrawczyk123 wants to merge 3 commits into
kkrawczyk123 wants to merge 3 commits into
Conversation
kkrawczyk123
commented
Oct 2, 2026
kkrawczyk123
commented
Collaborator
- update selectors for receiving pages
- fix for putaway candidate leftover
- adjust receiving tests to new receiving ui
alannadolny
reviewed
Oct 2, 2026
Comment on lines
+33
to
+39
| /** | ||
| Recalculates product_availability for a location from the transaction | ||
| ledger. Putaway candidates are read from product_availability rather than | ||
| the ledger directly, so a candidate can go stale (stuck at a quantity the | ||
| ledger no longer backs) after a shipment gets rolled back and deleted; | ||
| this is the app's own admin action for reconciling it. | ||
| */ |
Collaborator
There was a problem hiding this comment.
The comment is about putaways, and the service is related to putaways, but the method should be generic. It's not only for putaways, so it should be in a different file, with a more generic comment
Comment on lines
+35
to
+37
| return this.shimpentInformation.locator( | ||
| '.item-details__field:has-text("Origin:") .item-details__value' | ||
| ); |
Comment on lines
+349
to
+350
| await expect(receivingPage.receivingStep.autosaveStatus).toContainText( | ||
| 'Your work is auto-saved' |
Collaborator
There was a problem hiding this comment.
i think the autosaveStatus can have assertions inside methods, I mean:
await receivingPage.receivingStep.autosaveStatus.isSaved()
etc.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.