Return a catchable error instead of panicking on pathological encode input - #150
Open
AbhinavMir wants to merge 1 commit into
Open
Return a catchable error instead of panicking on pathological encode input#150AbhinavMir wants to merge 1 commit into
AbhinavMir wants to merge 1 commit into
Conversation
fancy_regex's find_iter/find_from_pos return a Result and can fail with RuntimeError(StackOverflow) when the backtracking engine exceeds its stack limit, for example on a very long single-character run. CoreBPE::encode_ordinary and CoreBPE::encode unwrapped those results, turning the error into a panic that surfaced in Python as an uncatchable pyo3_runtime.PanicException and could abort host processes. Add an EncodeError type and propagate the regex error through encode_ordinary, encode, encode_with_special_tokens, and _encode_unstable_native instead of unwrapping. Map it to HarmonyError at the PyO3 boundary and to a JsValue error at the wasm boundary so callers receive a normal catchable exception. Add Rust and Python regression tests for the long single-character run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#93