Fix/sampler shutdown lifecycle#8574
Open
Debashismitra01 wants to merge 4 commits into
Open
Conversation
230786a to
333c143
Compare
333c143 to
83b70e5
Compare
Contributor
|
d8eb3fa to
f246d3e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8574 +/- ##
============================================
+ Coverage 90.96% 91.56% +0.59%
- Complexity 10207 10266 +59
============================================
Files 1013 1013
Lines 27160 27115 -45
Branches 3182 3184 +2
============================================
+ Hits 24706 24827 +121
+ Misses 1730 1564 -166
Partials 724 724 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds shutdown lifecycle support to Samplers.
Previously Sampler implementations had no way to release resources when
SdkTracerProvider was shut down. Resource-owning samplers such as
JaegerRemoteSampler could leave background executors and connections running.
This change:
Fixes #8535