Retry on Unavailable gRPC errors, reduce result channel buffer - #56
Merged
Merged
Conversation
Retry when the connection drops (codes.Unavailable); gRPC reconnects on the next attempt so these errors are transient. Reduce the script result channel buffer from 10000 to 500 to apply backpressure to producers earlier and bound memory usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
codes.Unavailableto the retryable gRPC status codes in the unary clientinterceptor. Connection drops surface as Unavailable and are transient: gRPC
reconnects on the next attempt.
Reduce the
ScriptResultProcessorresults channel buffer from 10000 to 500 soproducers get backpressure earlier and memory usage stays bounded.
Most critical file to review:
client/interceptors/uci_retry.go.For contributor use:
mainbranchFiles changedin the Github PR explorer