use readTwoBigInts helper in signatureNormalizeS and signatureFlipS - #47
Closed
vishalchangrani wants to merge 1 commit into
Closed
use readTwoBigInts helper in signatureNormalizeS and signatureFlipS#47vishalchangrani wants to merge 1 commit into
vishalchangrani wants to merge 1 commit into
Conversation
Replace direct big.Int.SetBytes calls with the readTwoBigInts helper for consistency with the rest of the ECDSA code that reads (R, S) components from a serialized signature. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tarakby
reviewed
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signatureNormalizeS(and the test-onlysignatureFlipS) read S out of the signature buffer with a rawnew(big.Int).SetBytes(sig[nLen:])call, while the rest of the ECDSA code uses thereadTwoBigIntshelper for the same job._, s := readTwoBigInts(sig, nLen)so the (R, S) parsing pattern is uniform across the package.Stacked on top of #46 (which is stacked on top of #44).
Test plan
CGO_ENABLED=1 go build ./...CGO_ENABLED=1 go test -run 'TestECDSA|TestSignatureFormatCheck' -count=1 ./...🤖 Generated with Claude Code