win-dshow: Close device dialogs during shutdown - #13841
Open
prgmitchell wants to merge 1 commit into
Open
Conversation
Prevent OBS from hanging during shutdown by enumerating the DirectShow thread's windows and posting WM_CLOSE to all visible dialogs before waiting for the thread to exit.
RytoEX
requested review from
Fenrirthviti,
Lain-B,
RytoEX,
Warchamp7 and
notr1ch
September 9, 2026 22:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent OBS from hanging during shutdown by enumerating the DirectShow thread's windows and posting WM_CLOSE to all visible dialogs before waiting for the thread to exit. I did add a window visibility check because I logged every window being closed while testing and saw a bunch of windows that were not visible, not sure if this is necessary and can remove if not.
Motivation and Context
I have just been scrolling through issues looking for ones that seem pretty easy/straight forward to fix.
Fixes #13534
How Has This Been Tested?
Opened the configure video window from a video capture device source, closed the main OBS window which now resulted in the configure video window closing as expected.
Types of changes
Checklist: