Repository navigation
Fix signed Android release workflow - #547
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The workflow changes are coherent, preserve existing artifact names, and address the retired actions without identified regressions.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Android release automation to build the published tag and upload signed APKs using supported GitHub Actions tooling.
Changes:
- Uses checkout v4, JDK 17, and Gradle caching.
- Uploads versioned APKs through GitHub CLI with appropriate permissions.
- Removes deprecated cache, upload action, and step-output syntax.
| File | Description |
|---|---|
.github/workflows/releases.yml |
Modernizes signed APK build and release upload workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing v0.9.0 failed before compilation because the release workflow used the retired
actions/cache@v2. Use the same JDK 17 setup and Gradle caching as Android CI, update checkout, and explicitly build the published tag.Replace the legacy upload action and deprecated step outputs with GitHub CLI uploads using the workflow token with
contents: write. Preserve signed release builds and the existingOpenBot-<version>.apkandController-<version>.apkfilenames.Validation: actionlint, shell syntax checks, and a mocked upload confirming both filenames and APK contents passed. The real signed build and upload will be verified when v0.9.0 is recreated after merge.