fix: split legal name question into two separate - #120
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit fba3c2a): https://dev-nwplus-admin--pr120-34542208896-ugken00x.web.app (expires Sun, 20 Sep 2026 23:28:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c290bf9e2fac0401389f751f415cce4267517b51 |
Contributor
|
lgtm |
dymackenzie
approved these changes
Sep 11, 2026
|
goats |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
\https://nwplus2026-2027.slack.com/archives/C0B1486JYM9/p1788921902941879?thread_ts=1788770333.610259&cid=C0B1486JYM9
MLH needs 2 separate questions for first and last name
Current admin only allowed one full legal name question and automatically split the input into the 2 fields
Explanation
Allow legalFirstName and legalLastName questions to be asked separately
Mutually exclusive with the full legal name question.
Other considerations
Tested on dev
legalFirstName and legalLastName is under Basics -> short answer questions