[16.0][FIX] queue_job: rebind args/kwargs lazily to the job's current cursor#1
Draft
eantones wants to merge 2 commits into
Draft
[16.0][FIX] queue_job: rebind args/kwargs lazily to the job's current cursor#1eantones wants to merge 2 commits into
eantones wants to merge 2 commits into
Conversation
eantones
force-pushed
the
16.0-fix-queue_job-rebind-args-in-temporary-env-lazy
branch
from
5194f7c to
af4f40b
Compare
eantones
force-pushed
the
16.0-fix-queue_job-rebind-args-in-temporary-env-lazy
branch
from
af4f40b to
8b16a58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazy-shape alternative to the 16.0 args/kwargs rebinding fix, published for comparison. Not meant to merge here.
args/kwargs are stored in private attributes and exposed as properties that rebind any recordset inside to self.env.cr on access (cursor-only swap, uid/su/context are kept). in_temporary_env() stays a plain env swap. Same regression test as the eager shape.