doc: adds Charter - #182
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
It introduces governance/operational and security-documentation concerns (CODEOWNERS change reducing TSC review on governance, and public exposure of personal emails in README) that should be addressed before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Node.js Web Team governance repo to reflect chartering as the “Node.js Web Working Group”, adds the charter directly to the README, and aligns related governance/onboarding/security documentation and automation with the new structure.
Changes:
- Replaces “Web Team” wording with “Web WG / Web Working Group” across key docs and meeting process docs.
- Adds a detailed WG charter and moves the member list from
MEMBERS.mdintoREADME.md. - Updates the inactive-collaborator report script to source members from
README.md, and adjusts CODEOWNERS.
File summaries
| File | Description |
|---|---|
| SECURITY.md | Updates security policy wording from Web Team to Web WG. |
| README.md | Introduces WG charter/governance content and embeds the members list. |
| onboarding/README.md | Updates onboarding instructions to refer to the new members location and WG naming. |
| MEMBERS.md | Removes the standalone members file (members now in README). |
| meetings/README.md | Renames meeting docs from Web Team to Web WG terminology. |
| GOVERNANCE.md | Updates governance naming and adds OpenJS oversight/content guidance. |
| .github/scripts/inactive-collaborator-report.mjs | Switches member parsing to README.md and updates the expected section header. |
| .github/CODEOWNERS | Removes the TSC codeowner entry for GOVERNANCE.md. |
Review details
Suppressed comments (2)
README.md:102
- Same concern as above: these email addresses are directly exposed in the public README and are not needed to identify members. Removing them reduces unnecessary personal data exposure.
- [@MoLow](https://github.com/MoLow) - **Moshe Atlow** <<moshe@atlow.co.il>> (he/him)
- [@ovflowd](https://github.com/ovflowd) - **Claudio Wunder** <<cwunder@gnome.org>> (they/them)
onboarding/README.md:7
- Same terminology issue as above: the link text currently says "@nodejs/web WG". Use the full working group name and the handle for clarity/consistency.
Before onboarding the **Nominee**, ensure they have read and understand [the governance of the @nodejs/web WG](../GOVERNANCE.md).
- Files reviewed: 8/8 changed files
- Comments generated: 7
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ### Outside the Charter | ||
|
|
||
| - **Editorial positions.** Chartering does not change the | ||
| [TSC Oversight](GOVERNANCE.md#tsc-oversight) clause described about global positions or events. | ||
| - **Foundation, Partner, Marketing, or Collaborator content.** Chartering does not change [content input](GOVERNANCE.md#openjs-oversight-and-content-input) from stakeholders that have [content vs. code][] scope. | ||
| - **Shared infrastructure.** Cloudflare is owned by the [Build WG][]; the Web WG | ||
| holds scoped access only. Changes to that boundary require agreement from the | ||
| Build WG. | ||
| - **Anything not listed above.** Work outside these responsibilities remains with | ||
| the TSC. | ||
|
|
||
| Within the charter, the TSC's only recourse over a Working Group is to revoke its | ||
| charter. |
There was a problem hiding this comment.
Is this needed or this already known?
There was a problem hiding this comment.
it feels important to draw clear boundaries. i've felt that a lot of this was redundant with what was already in place, but we are just reframing to confirm with the template
Co-authored-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
blocking until nodejs/TSC#1888 resolves |
|
|
||
| For the current list of WG members, see [Members](#members). | ||
|
|
||
| ## Charter |
There was a problem hiding this comment.
This should sit in GOVERNANCE.md
| The moderator is responsible for summarizing the discussion of each agenda item | ||
| and sends it as a pull request to [meetings/](meetings) after the meeting. | ||
|
|
||
| ## Consensus Seeking Process |
There was a problem hiding this comment.
You should have a decision making system that works without having a meeting.
|
|
||
| ## Consensus Seeking Process | ||
|
|
||
| The WG follows a [Consensus Seeking][] decision-making model. |
|
technically it's the reverse. This should land first, and that's the one the TSC should approve. |
Relates to nodejs/TSC#1888 and should not merge until that one does
Shapes the existing README.md and adjacent files to be conformant to the template within https://github.com/nodejs/TSC/blob/main/WORKING_GROUPS.md