Skip to content

fix: correct the code style in the hover status #9142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btea wants to merge 6 commits into
base: main
Choose a base branch
from
+30 −7
Open

fix: correct the code style in the hover status #9142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9abb1a0
fix: correct the code style in the hover status
btea Sep 4, 2026
9880821
Refactor hover and focus styles for light theme
btea Sep 4, 2026
f19b0f5
style: update
btea Sep 4, 2026
7cb0462
fix: update
btea Sep 4, 2026
5fc285a
chore: add changeset
btea Sep 5, 2026
6cca73c
chore: update comment
btea Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/crisp-socks-call.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@node-core/ui-components': patch
---

In the light theme, the background color of items in the history change component that contain code elements is incorrect when hovering.
2 changes: 1 addition & 1 deletion packages/ui-components/.storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const preview: Preview = {

decorators: [
withThemeByDataAttribute<ReactRenderer>({
themes: { light: '', dark: 'dark' },
themes: { light: 'light', dark: 'dark' },

@btea btea Sep 4, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add specific attribute values ​​to ensure that the newly added class can be matched in the storybook.

defaultTheme: 'light',
attributeName: 'data-theme',
}),
Expand Down
7 changes: 7 additions & 0 deletions packages/ui-components/src/Common/ChangeHistory/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,13 @@
@apply bg-brand-600
text-white!;
}

/* Keep inline `code` readable in light theme, where hover/focus turns text white */
:where([data-theme='light'], [data-theme='light'] *)
&:is(:hover, :focus-visible)
code {
@apply text-brand-900;
}
}

.dropdownLabel {
Expand Down
23 changes: 17 additions & 6 deletions packages/ui-components/src/Common/ChangeHistory/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ const SAMPLE_CHANGES = [
{
versions: ['v15.0.0', 'v14.17.0'],
label: 'Added in v15.0.0, v14.17.0',
content: (
<>
Added in: <code>v15.0.0</code>, <code>v14.17.0</code>
</>
),
url: 'https://github.com/nodejs/node/pull/67890',
},
{
Expand Down Expand Up @@ -107,9 +112,13 @@ const LARGE_SAMPLE_CHANGES = [

export const Default: Story = {
render: args => (
<div className="right-0 flex justify-end">
<ChangeHistory {...args} />
</div>
// `main` reproduces the docs page context: markdown.css scopes inline
// `code` styles under `main`, which is what the hover fix interacts with /ui-components/src/styles/markdown.css
<main>
<div className="flex justify-end">
<ChangeHistory {...args} />
</div>
</main>
),
args: {
changes: SAMPLE_CHANGES,
Expand All @@ -118,9 +127,11 @@ export const Default: Story = {

export const LargeHistory: Story = {
render: args => (
<div className="right-0 flex justify-end">
<ChangeHistory {...args} />
</div>
<main>
<div className="flex justify-end">
<ChangeHistory {...args} />
</div>
</main>
),
args: {
changes: LARGE_SAMPLE_CHANGES,
Expand Down