docs(learn): correct another example code for the consumption of response body - #8332
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tenkirin
force-pushed
the
docs/correct-example-code-2
branch
from
November 5, 2025 09:31
28dbade to
902ed4b
Compare
tenkirin
marked this pull request as draft
November 5, 2025 09:38
tenkirin
force-pushed
the
docs/correct-example-code-2
branch
from
November 5, 2025 09:49
902ed4b to
e4d7028
Compare
tenkirin
marked this pull request as ready for review
November 5, 2025 09:49
avivkeller
approved these changes
Nov 5, 2025
avivkeller
left a comment
Member
There was a problem hiding this comment.
Thanks! In the future, there's no need to open an issue for these little things. In fact, if you want, you can also group them all into a single PR.
mikeesto
approved these changes
Nov 6, 2025
avivkeller
enabled auto-merge
November 6, 2025 15:35
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8332 +/- ##
==========================================
+ Coverage 76.72% 76.74% +0.02%
==========================================
Files 118 118
Lines 9805 9805
Branches 335 335
==========================================
+ Hits 7523 7525 +2
+ Misses 2280 2278 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs, fix #8331.
Added
await response.body?.cancel();to explicitly destroy the response body before throwing an error.if (!response.ok || !response.body) { + // consuming the response body is mandatory: https://undici.nodejs.org/#/?id=garbage-collection + await response.body?.cancel(); throw new Error(`Failed to fetch ${url}. Status: ${response.status}`); }Validation
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.