doc: clarify Worker execArgv vs Permission Model grants - #66124
Open
yunshingng wants to merge 4 commits into
Open
yunshingng wants to merge 4 commits into
yunshingng wants to merge 4 commits into
Conversation
Omit execArgv: the worker keeps the parent's CLI flags, including --permission and --allow-*. Explicit execArgv (including []) replaces inheritance and can drop those grants. That is intended. Documented after nodejs#65359. No runtime change. Refs: nodejs#65359 Signed-off-by: yunshingng <yunshingng25@gmail.com>
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
2 tasks
Signed-off-by: yunshingng <yunshingng25@gmail.com>
Signed-off-by: yunshingng <yunshingng25@gmail.com>
Signed-off-by: yunshingng <yunshingng25@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #65359.
Rafael asked to keep the current runtime behavior and only clarify the docs.
This PR does not change
src/. It states:execArgv: the worker keeps the parent CLI flags (--permission,--allow-*if the parent has them).execArgv, including[]: inheritance is replaced; Permission Model grants from the parent are not kept unless listed again.Test plan