benchmark: remove duplicate ffi add-64 benchmark - #66121
Open
soulee-dev wants to merge 1 commit into
Open
soulee-dev wants to merge 1 commit into
soulee-dev wants to merge 1 commit into
Conversation
add-64.js measured the same add_f64 symbol with the same signature as add-f64.js and differed only in its argument constants. Signed-off-by: Soul Lee <alus20x@gmail.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benchmark/ffi/add-64.jsandbenchmark/ffi/add-f64.jsmeasured the samething: both
dlopenthe fixture library, bindadd_f64with the signature{ return: 'f64', arguments: ['f64', 'f64'] }, and call itn = 1e7times.The only difference was the argument constants (
add(20.5, 21.5)vsadd(1.5, 2.5)), which does not change what is being measured.add-f64.jscame first (#62918).add-64.jswas added later in #63068 aspart of a batch of
add-*benchmarks; git records it as a copy ofadd-f64.jswith only the constants changed to that batch's convention, andnothing in the review of either PR treats it as a distinct case. Nothing in
benchmark/,doc/,test/ortools/references theadd-64name.This removes
add-64.jsand keepsadd-f64.js, whose name matches theadd_f64symbol it measures and the naming of the otheradd-<type>.jsfiles.
Verified locally:
Refs: #63068
Refs: #62918