Conversation
`IntervalHistogram` stored the interval as `int32_t`, so a resolution above 2^31 - 1 ms wrapped: `resolution: 2 ** 32 + 1` sampled every millisecond. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: OpenCode
It counts values above the highest recordable value, for every histogram type. Event loop delay histograms no longer have a 1 hour limit. Signed-off-by: James M Snell <jasnell@gmail.com> Refs: nodejs#41153 Assisted-by: OpenCode
Accept `lowest`, `highest`, and `figures`, as `createHistogram()` does. The defaults are unchanged, and use up to 432 KiB per histogram. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: OpenCode
jasnell
added
semver-minor
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66115 +/- ##
==========================================
- Coverage 90.27% 90.27% -0.01%
==========================================
Files 790 790
Lines 271651 271690 +39
Branches 51842 51848 +6
==========================================
+ Hits 245228 245257 +29
- Misses 16928 16935 +7
- Partials 9495 9498 +3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds options to tune histogram parameters to
monitorEventLoopDelay()Also fix a truncation and doc bug.