Skip to content

crypto: remove redundent std::move call - #66111

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:fewer-warnings
Open

aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:fewer-warnings

Conversation

@aduh95

@aduh95 aduh95 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

From https://github.com/nodejs/node/actions/runs/35364375159/job/105684098080:

../../deps/ncrypto/ncrypto.cc: In member function 'ncrypto::Result<ncrypto::DataPointer, ncrypto::EVPKeyPointer::RawExportError> ncrypto::EVPKeyPointer::rawSeed() const':
../../deps/ncrypto/ncrypto.cc:3603:19: warning: redundant move in return statement [-Wredundant-move]
 3603 |   return std::move(data);
      |          ~~~~~~~~~^~~~~~
../../deps/ncrypto/ncrypto.cc:3603:19: note: remove 'std::move' call
../../deps/ncrypto/ncrypto.cc: In member function 'ncrypto::Result<ncrypto::EVPKeyPointer::RawJwkData, ncrypto::EVPKeyPointer::RawExportError> ncrypto::EVPKeyPointer::exportRawJwk(bool) const':
../../deps/ncrypto/ncrypto.cc:3624:19: warning: redundant move in return statement [-Wredundant-move]
 3624 |   return std::move(data);
      |          ~~~~~~~~~^~~~~~
../../deps/ncrypto/ncrypto.cc:3624:19: note: remove 'std::move' call

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Sep 18, 2026
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 18, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 18, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants